Fixed rock sliding bug #532
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdheshb6
approved these changes
Oct 5, 2023
|
Complete the review section |
Ress-sama
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #499.
I noticed that, while the player is stuck on the rock, adjusting the minimum slope on the characterController to be around 90 allowed the player to move again. Therefore, I decided to implement a failsafe in Protagonist.cs that detects when the player is colliding with a rock, and if so, sets the minimum slope value to 90. When they leave the rock collider, the minimum slope is set back to its original value. Although this does not necessarily address the root of this bug, I found that it made for a good temporary fix.
After implementing the changes, this is how the character and rocks behaved on my laptop: https://imgur.com/a/l1vArnX