feat: Allow fulfillment method type (and id) to be optional on Fulfillment method updates#143
Open
matthutchinson wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
richmolj
approved these changes
Jan 29, 2026
jingyli
approved these changes
Jan 29, 2026
Contributor
jingyli
left a comment
There was a problem hiding this comment.
Thanks for catching this!
56b6889 to
6070635
Compare
Author
|
cc @jingyli updated slightly to also make |
6070635 to
aefcf81
Compare
aefcf81 to
dcffe5e
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fulfillment method type and id are now optional on Fulfillment Method update requests
Updates the schema to be more permissive, allowing fulfillment method
typeandidto be included in fulfillment method update requests (previously the schema defined thistypewithomitandidasrequired).Consider this example scenario;
Changing a the type of fulfillment on an already created checkout. E.g. create checkout with only a pickup fulfillment method, but agent wishes to update this to an entirely new shipping fulfillment method in an update request. In this case
typeshould be specified, butidwould be omitted in the input.Type of change
Checklist