Skip to content

feat: Allow fulfillment method type (and id) to be optional on Fulfillment method updates#143

Open
matthutchinson wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
matthutchinson:adjust-fulfillment-method-update-request-type-field
Open

feat: Allow fulfillment method type (and id) to be optional on Fulfillment method updates#143
matthutchinson wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
matthutchinson:adjust-fulfillment-method-update-request-type-field

Conversation

@matthutchinson
Copy link

@matthutchinson matthutchinson commented Jan 29, 2026

Fulfillment method type and id are now optional on Fulfillment Method update requests

Updates the schema to be more permissive, allowing fulfillment method type and id to be included in fulfillment method update requests (previously the schema defined this type with omit and id as required).

Consider this example scenario;

Changing a the type of fulfillment on an already created checkout. E.g. create checkout with only a pickup fulfillment method, but agent wishes to update this to an entirely new shipping fulfillment method in an update request. In this case type should be specified, but id would be omitted in the input.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@matthutchinson matthutchinson requested a review from a team January 29, 2026 17:38
@google-cla
Copy link

google-cla bot commented Jan 29, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@jingyli jingyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@matthutchinson matthutchinson force-pushed the adjust-fulfillment-method-update-request-type-field branch from 56b6889 to 6070635 Compare January 29, 2026 18:05
@matthutchinson matthutchinson changed the title feat: Allow fulfillment method type to be optional on Fulfillment method updates feat: Allow fulfillment method type (and id) to be optional on Fulfillment method updates Jan 29, 2026
@matthutchinson
Copy link
Author

cc @jingyli updated slightly to also make id optional here too, see updated example scenario in the PR description

@matthutchinson matthutchinson force-pushed the adjust-fulfillment-method-update-request-type-field branch from 6070635 to aefcf81 Compare January 29, 2026 23:18
@matthutchinson matthutchinson force-pushed the adjust-fulfillment-method-update-request-type-field branch from aefcf81 to dcffe5e Compare February 2, 2026 15:42
@matthutchinson
Copy link
Author

cc @jingyli / @richmolj just a nudge to see if we can merge this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants