chore: update ts schema generator to use files in source/#144
Open
wry-ry wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Open
chore: update ts schema generator to use files in source/#144wry-ry wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
wry-ry wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Conversation
yanheChen
approved these changes
Jan 30, 2026
Contributor
|
👋 if generated schema files are no longer hosted in the repo, should we really be pushing up the generated ts file here? Seems like this is also something we don't need to constantly push. |
Contributor
|
hey @raginpirate we internally using the JS generator to generate model against the proto, if we don't have ways to make sure it's not breaking generating, I would highly recommend we leave it there before we have a solid plan |
Contributor
|
@yanheChen is this repo the right place for these though? Why can't or shouldn't these live in the SDK? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update schema to generate_ts_schema_types.js to use source/ now that we have deleted the pre-processing step.
Type of change