Skip to content

fix!: Mark checkout id as deprecated_required_to_omit for update requests#145

Open
raginpirate wants to merge 2 commits intomainfrom
raginpirate/remove-redundant-checkout-id
Open

fix!: Mark checkout id as deprecated_required_to_omit for update requests#145
raginpirate wants to merge 2 commits intomainfrom
raginpirate/remove-redundant-checkout-id

Conversation

@raginpirate
Copy link
Contributor

@raginpirate raginpirate commented Jan 30, 2026

Dependency on Universal-Commerce-Protocol/ucp-schema#6

Description

This change simplifies the checkout request schema by marking the id field as deprecated from all request types. Today we do this correctly for complete, but for update we accept a checkout id in both the transport layer as well as the checkout object being provided. This was a miss dating back to the 2026-01-11 release.

Type of change

  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected, including removal of schema files
    or fields
    )
  • Documentation update

Is this a Breaking Change or Removal?

If you checked "Breaking change" above, or if you are removing any schema
files or fields:

  • I have added ! to my PR title (e.g., feat!: remove field).
  • I have added justification below.

Its very clear why this is needed; redundant context being sent between businesses and platforms.


Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@raginpirate raginpirate self-assigned this Jan 30, 2026
@raginpirate raginpirate requested a review from a team January 30, 2026 13:38
@raginpirate raginpirate changed the title feat!: Omit checkout id from update requests fix!: Omit checkout id from update requests Jan 30, 2026
@raginpirate raginpirate added the TC review Ready for TC review label Jan 30, 2026
Copy link

@knightlin-shopify knightlin-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to omit the id field for all the request. The id should be specified outside of checkout object (REST will be on the URL, MCP will be on parent object).

@igrigorik igrigorik added this to the Working Draft milestone Feb 3, 2026
@raginpirate raginpirate requested a review from jingyli February 4, 2026 16:32
@raginpirate raginpirate changed the title fix!: Omit checkout id from update requests fix: Mark checkout id as deprecated_required_to_omit for update requests Feb 6, 2026
@raginpirate raginpirate changed the title fix: Mark checkout id as deprecated_required_to_omit for update requests fix!: Mark checkout id as deprecated_required_to_omit for update requests Feb 6, 2026
@raginpirate raginpirate force-pushed the raginpirate/remove-redundant-checkout-id branch from 80668d3 to e2c2d33 Compare February 9, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TC review Ready for TC review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants