feat: add ec_color_scheme query parameter to embedded checkouts #157
+47
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow hosts to specify color scheme preference (light/dark/auto) when loading embedded checkout, enabling visual consistency with host apps.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
lemonmade
approved these changes
Feb 5, 2026
igrigorik
reviewed
Feb 5, 2026
Breaking Changes / Removal Justification(Please provide a detailed technical and strategic rationale here for why this |
igrigorik
requested changes
Feb 10, 2026
Contributor
igrigorik
left a comment
igrigorik
left a comment
There was a problem hiding this comment.
A few more suggestions.
|
|
||
| - By default, the Embedded Checkout **SHOULD** respect the buyer's system | ||
| color scheme preference and listen for changes to update accordingly | ||
| - When `ec_color_scheme` is explicitly provided, it **SHOULD** override the |
Contributor
There was a problem hiding this comment.
Suggested change
| - When `ec_color_scheme` is explicitly provided, it **SHOULD** override the | |
| - When `ec_color_scheme` is explicitly provided, it **MUST** override the |
| color scheme preference and listen for changes to update accordingly | ||
| - When `ec_color_scheme` is explicitly provided, it **SHOULD** override the | ||
| system preference and be applied immediately upon load | ||
| - The color scheme is a hint; businesses **MAY** ignore unsupported values |
Contributor
There was a problem hiding this comment.
Suggested change
| - The color scheme is a hint; businesses **MAY** ignore unsupported values | |
| - Businesses **MAY** ignore unsupported values |
|
|
||
| **Default Behavior:** | ||
|
|
||
| When `ec_color_scheme` is not provided, the Embedded Checkout **SHOULD** |
Contributor
There was a problem hiding this comment.
When `ec_color_scheme` is not provided, the Embedded Checkout can
| **Default Behavior:** | ||
|
|
||
| When `ec_color_scheme` is not provided, the Embedded Checkout **SHOULD** | ||
| respect the buyer's system preference via the |
Contributor
There was a problem hiding this comment.
Suggested change
| respect the buyer's system preference via the | |
| use the buyer's system preference via the |
Keep this paragraph as "can", we define the must/should below.
| - By default, the Embedded Checkout **SHOULD** respect the buyer's system | ||
| color scheme preference and listen for changes to update accordingly | ||
| - When `ec_color_scheme` is explicitly provided, it **SHOULD** override the | ||
| system preference and be applied immediately upon load |
Contributor
There was a problem hiding this comment.
Suggested change
| system preference and be applied immediately upon load | |
| system preference, be applied immediately upon load, and be enforced | |
| for the duration of the session. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow hosts to specify color scheme preference (light/dark/auto) when loading embedded checkout, enabling visual consistency with host apps.
Type of change
Please delete options that are not relevant.
functionality to not work as expected, including removal of schema files
or fields)
Is this a Breaking Change or Removal?
If you checked "Breaking change" above, or if you are removing any schema
files or fields:
!to my PR title (e.g.,feat!: remove field).Checklist