Skip to content

Conversation

@misza-one
Copy link

@misza-one misza-one commented Feb 8, 2026

Description

Updates generate_ts_schema_types.js to reference source/ instead of the removed spec/ directory. The spec/ directory was removed in #125, but this script was not updated — running it currently finds 0 schemas.

Single line change on line 5:

-const SOURCE_ROOT = path.resolve(__dirname, 'spec');
+const SOURCE_ROOT = path.resolve(__dirname, 'source');

Fixes #150

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@misza-one misza-one requested a review from a team February 8, 2026 19:16
@google-cla
Copy link

google-cla bot commented Feb 8, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

The generate_ts_schema_types.js script still referenced the removed
spec/ directory. Updated to use source/ which is where schemas now
live after the migration in Universal-Commerce-Protocol#125.

Fixes Universal-Commerce-Protocol#150
@misza-one misza-one force-pushed the fix/ucp-150-ts-schema-path branch from a47bdaa to d4af096 Compare February 8, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: TypeScript type generator references removed spec/ directory

1 participant