Skip to content

Conversation

@misza-one
Copy link

@misza-one misza-one commented Feb 8, 2026

Description

Fixes the order capability example to use "fulfillment" instead of "shipping" in the totals array. The Total schema defines the type enum as: items_discount, subtotal, discount, fulfillment, tax, fee, total. The value shipping is not valid for totals.

Single line change in docs/specification/order.md:

-    { "type": "shipping", "amount": 1200 },
+    { "type": "fulfillment", "amount": 1200 },

Note: Other "type": "shipping" occurrences in the codebase are in fulfillment.methods[].type context, which correctly references fulfillment_method.json (enum: shipping, pickup). Only this totals example was using the wrong value.

Fixes #63

Type of change

  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@misza-one misza-one requested a review from a team February 8, 2026 19:16
@google-cla
Copy link

google-cla bot commented Feb 8, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@misza-one misza-one changed the title fix: use fulfillment instead of shipping in order totals example docs: use fulfillment instead of shipping in order totals example Feb 8, 2026
The order capability example used "shipping" as a total type, but the
Total Response schema enum defines it as "fulfillment". Updated the
example to match the schema definition.

Fixes Universal-Commerce-Protocol#63
@misza-one misza-one force-pushed the fix/ucp-63-order-totals-enum branch from 48c419e to d518e6b Compare February 8, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistency between Total Response type enum and example in Order Capability

1 participant