-
Notifications
You must be signed in to change notification settings - Fork 264
chore: Trying to enable the CI checks #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…/ transports (#28) * Use a consistent schema for complete operations * Update type generator to omit unused types
| @@ -1,3 +1,19 @@ | |||
| [project] | |||
| name = "ucp" | |||
| version = "0.1.0" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the version be 20260111?
| --link-mode=copy \ | ||
| --extra-index-url https://pypi.org/simple python \ | ||
| -m datamodel_code_generator \ | ||
| --with "datamodel-code-generator[ruff]" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be kept in sync with https://github.com/Universal-Commerce-Protocol/python-sdk/blob/main/generate_models.sh; perhaps even add a comment to that effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this script run in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems has been run here: https://github.com/Universal-Commerce-Protocol/ucp/blob/main/.github/workflows/docs.yml#L28
|
this could wait after the merging has been finished. But should fix the deployment CI triggering when the merge has been done. |
ef88c8a to
454f9d9
Compare
Description
This PR initializes the Python project configuration in
pyproject.tomland updates theci_check_models.shscript to leverageuvfor dependency management and execution.Key changes:
pyproject.tomlwith project metadata and dependencies (specificallydatamodel-code-generator[ruff]).scripts/ci_check_models.shto useuv runwith the--withflag for ephemeral dependency installation.ruffformatters to the data model generation process in the CI script.uv.lockfile to pin dependencies.Type of change
Please delete options that are not relevant.
Is this a Breaking Change or Removal?
If you checked "Breaking change" above, or if you are removing any schema
files or fields:
!to my PR title (e.g.,feat!: remove field).