Skip to content

Conversation

@yanheChen
Copy link
Contributor

Description

This PR initializes the Python project configuration in pyproject.toml and updates the ci_check_models.sh script to leverage uv for dependency management and execution.

Key changes:

  • Populated pyproject.toml with project metadata and dependencies (specifically datamodel-code-generator[ruff]).
  • Updated scripts/ci_check_models.sh to use uv run with the --with flag for ephemeral dependency installation.
  • Added ruff formatters to the data model generation process in the CI script.
  • Added uv.lock file to pin dependencies.

Type of change

Please delete options that are not relevant.

  • Chore (Changes to the build process or auxiliary tools and libraries)

Is this a Breaking Change or Removal?

If you checked "Breaking change" above, or if you are removing any schema
files or fields:

  • I have added ! to my PR title (e.g., feat!: remove field).
  • I have added justification below.

lemonmade and others added 3 commits January 16, 2026 13:04
…/ transports (#28)

* Use a consistent schema for complete operations

* Update type generator to omit unused types
@yanheChen yanheChen requested review from a team and wry-ry January 16, 2026 19:31
@yanheChen yanheChen changed the title [chore]expereimental for the ci_check chore: expereimental for the ci_check Jan 16, 2026
@0x8000-0000 0x8000-0000 changed the title chore: expereimental for the ci_check chore: fully enable the CI checks Jan 16, 2026
@@ -1,3 +1,19 @@
[project]
name = "ucp"
version = "0.1.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the version be 20260111?

--link-mode=copy \
--extra-index-url https://pypi.org/simple python \
-m datamodel_code_generator \
--with "datamodel-code-generator[ruff]" \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be kept in sync with https://github.com/Universal-Commerce-Protocol/python-sdk/blob/main/generate_models.sh; perhaps even add a comment to that effect.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this script run in CI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanheChen yanheChen changed the title chore: fully enable the CI checks chore: Trying to enable the CI checks Jan 16, 2026
@yanheChen
Copy link
Contributor Author

this could wait after the merging has been finished. But should fix the deployment CI triggering when the merge has been done.

@yanheChen yanheChen marked this pull request as draft January 16, 2026 19:39
Base automatically changed from working-draft to main January 23, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants