Skip to content

docs: use fulfillment instead of shipping in order totals example#76

Open
muzaffersenkal wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
muzaffersenkal:docs/order-totals-shipping-to-fulfillment
Open

docs: use fulfillment instead of shipping in order totals example#76
muzaffersenkal wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
muzaffersenkal:docs/order-totals-shipping-to-fulfillment

Conversation

@muzaffersenkal
Copy link

Description

Fixes #63

The example in the Order Capability documentation used "type": "shipping" in the totals array, but the schema defines the enum as:

  • items_discount
  • subtotal
  • discount
  • fulfillment
  • tax
  • fee
  • total

Updated the example to use fulfillment to match the schema definition.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@muzaffersenkal muzaffersenkal requested a review from a team January 18, 2026 12:36
Copy link

@surgarbear56-debug surgarbear56-debug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--- deleted personal information ---

@muzaffersenkal
Copy link
Author

Hi @igrigorik , a reviewer on this PR seems to have publicly shared sensitive personal information. Could you please remove them as reviewer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistency between Total Response type enum and example in Order Capability

2 participants