pkg(com.miui.cloudservice and com.miui.micloudsync): categorize them as Advanced #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonymousWP
added
the
package::documentation
AnonymousWP
requested changes
Jan 15, 2025
| @@ -15122,11 +15122,11 @@ | |||
| }, | |||
| "com.miui.cloudservice": { | |||
| "list": "Oem", | |||
| "description": "Mi Cloud Services needed for Mi Cloud\n", | |||
| "description": "Dependency for synchronizing data with Xiaomi Cloud, including photos, contacts, messages, etc.\n", | |||
There was a problem hiding this comment.
Suggested change
| "description": "Dependency for synchronizing data with Xiaomi Cloud, including photos, contacts, messages, etc.\n", | |
| "description": "Dependency for synchronizing data with Xiaomi Cloud, including photos, contacts, messages, etc.\nThis feature is important for Xiaomi phone users in China since Xiaomi Cloud serves this market.", |
| @@ -15186,11 +15186,11 @@ | |||
| }, | |||
| "com.miui.micloudsync": { | |||
| "list": "Oem", | |||
| "description": "Mi Cloud Sync\nNeeded for Cloud synchronization.", | |||
| "description": "Dependency for synchronizing data with Xiaomi Cloud, including photos, contacts, messages, etc.\n", | |||
There was a problem hiding this comment.
Suggested change
| "description": "Dependency for synchronizing data with Xiaomi Cloud, including photos, contacts, messages, etc.\n", | |
| "description": "Dependency for synchronizing data with Xiaomi Cloud, including photos, contacts, messages, etc.\nThis feature is important for Xiaomi phone users in China since Xiaomi Cloud serves this market.", |
| "dependencies": [], | ||
| "neededBy": [], | ||
| "labels": [], | ||
| "removal": "Recommended" | ||
| "removal": "Advanced" |
There was a problem hiding this comment.
Suggested change
| "removal": "Advanced" | |
| "removal": "Recommended" |
| "dependencies": [], | ||
| "neededBy": [], | ||
| "labels": [], | ||
| "removal": "Recommended" | ||
| "removal": "Advanced" |
There was a problem hiding this comment.
Suggested change
| "removal": "Advanced" | |
| "removal": "Recommended" |
|
@AnonymousWP Thanks for your feedback. I recommend maintaining the merge request in its current state and retaining the "Advanced" categorization for these packages, based on the following considerations:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of January 2025, I have to manually enable
com.miui.cloudserviceandcom.miui.micloudsyncso that data synchronization with Xiaomi Cloud works as expected. This feature is important for Xiaomi phone users in China since Xiaomi Cloud serves this market. More information is available at https://i.mi.com/.