Detect Confluence-exported DOC files stored in FileContents stream#4374
Open
zanvari wants to merge 1 commit into
Open
Detect Confluence-exported DOC files stored in FileContents stream#4374zanvari wants to merge 1 commit into
zanvari wants to merge 1 commit into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Shadow auto-approve: would auto-approve. Adds detection of Confluence-exported DOC files by recognizing a FileContents OLE stream. The change is small, well-tested, and only affects file type detection logic without impacting broader processing.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3980.
Some Confluence-exported legacy
.docfiles are stored as OLE/CFB containers but do not contain the standardWordDocumentstream used for DOC detection. Instead, they store document content in aFileContentsstream.This change extends
_OleFileDetectorto recognizeFileContentsas a valid DOC indicator and returnFileType.DOC.Changes
FileContentsstream asFileType.DOCTesting
Result: