Nullness checker case study on the Server side of LockdownTraveller.#1
Open
UtR491 wants to merge 1 commit intominimal-mainfrom
Open
Nullness checker case study on the Server side of LockdownTraveller.#1UtR491 wants to merge 1 commit intominimal-mainfrom
UtR491 wants to merge 1 commit intominimal-mainfrom
Conversation
UtR491
force-pushed
the
annotated-minimal
branch
from
0d96763 to
40e3c25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DisplayTrainsRequestHandler.java file had very sloppy exception handling. In DisplayTrains() function, there were several try-catch blocks written just to handle the same checked exception as and when it arose. Some of them only had assignments! This resulted in many warnings too, like variable x might not have been initialized, which resulted in vague initialization on declaration and also many redundant
assert x != nullstatements. The best way to counter it was to put the entire function in on try block. This resulted in a very large diff size for the particular file. To contain this to an extent, the indentation is a little bit off but it should make the review more convenient.