Skip to content

Fixed SQL for postgres in java code for Community annotations from Ap… #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed SQL for postgres in java code for Community annotations from Ap… #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...src/main/java/org/apidb/apicommon/service/services/jbrowse/JBrowseFeatureDataFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,9 +235,9 @@ private StreamingOutput getFeaturesOutput(String featureSql, String bulkSubfeatu
String sortedSubfeatureSql =
" select * from (" +
" select a.*," +
" (case when b.parent_id is null then to_char(a.parent_id) else to_char(b.parent_id) end) as top_parent_id" +
" (case when b.parent_id is null then a.parent_id else b.parent_id end) as top_parent_id" +
" from " + wrappedSubfeatureSql + " a" +
" left join " + wrappedSubfeatureSql + " b on to_char(a.parent_id) = to_char(b.feature_id)" +
" left join " + wrappedSubfeatureSql + " b on a.parent_id = b.feature_id" +
" )" +
" order by top_parent_id asc";

Expand Down Expand Up @@ -458,7 +458,7 @@ private static void appendAttributes(JSONObject json, ResultSet rs) throws SQLEx

private Optional<Range<Integer>> findFeatureRange(String featureSql, String queryName) {
// find range of selected features
String rangeSql = "select min(startm) as min_start, max(end) as max_end from ( " + featureSql + " )";
String rangeSql = "select min(startm) as min_start, max(\"end\") as max_end from ( " + featureSql + " )";
return new SQLRunner(_appDs, rangeSql, queryName).executeQuery(rs -> {
if (!rs.next()) return Optional.empty();
int minStart = rs.getInt("min_start");
Expand Down