Replace deprecated defaultProps with modern default parameters [Claude Code Web] #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The defaultProps property for functional components is deprecated in React. This commit replaces all instances of defaultProps with ES6 default parameter syntax in functional components. Changes: - RecordActionLink.jsx: Use destructured params with defaults - Sequence.tsx: Use destructured params with defaults - FieldFilter.jsx: Use destructured params with defaults - ServerSideAttributeFilter.jsx: Use destructured params with defaults - CheckboxTree.tsx: Use destructured params with defaults - SelectTree.tsx: Use destructured params with defaults Class components were left unchanged as defaultProps is still valid for them.
bobular
changed the title
SelectTreeProps extends CheckboxTreeProps, so we should only destructure SelectTree-specific properties and leave CheckboxTree props to be accessed via props for proper type checking.
Properties that have default values in the function signature should be marked as optional in the TypeScript interface to maintain type consistency.
Update helper function parameter types to match the guaranteed non-nullable types after default values are applied. This resolves type errors while maintaining type safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely not needed if the TypeScript conversions work out.
Note that Ann has already tackled this a year ago in #1226
Not sure if there are merge conflicts with that 1yr old PR. We should compare the approaches.
The defaultProps property for functional components is deprecated in React. This commit replaces all instances of defaultProps with ES6 default parameter syntax in functional components.
Changes:
Class components were left unchanged as defaultProps is still valid for them.