Migrate from react-json-viewer to json-edit-react #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom component with same functionalities was made using bootstrap components Package was deleted from the project Replaced import of multiselect in edit-config.js Signed-off-by: Andrii Podriez <[email protected]>
Relaced the package with navigator.clipboard call Signed-off-by: Andrii Podriez <[email protected]>
Replaced ReactJson components from previous package with new JsonEditor components Removed react-json-view dependency Signed-off-by: Andrii Podriez <[email protected]>
Replaced data handling with a single function Updated validation function in edit-config dialogue Adjusted the size of the json editor box Signed-off-by: Andrii Podriez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced deprecated react-json-viewer dependency with json-edit-react