Repository navigation
Stop running the update check twice for diffly setup - #16
Merged
VIVAAN-DHAWAN merged 1 commit intoAug 23, 2026
Merged
Conversation
Diffly verdict: QUARANTINE#16 · 2 files · 21 lines changed · checks: PENDING Risk flags: Risk flags and reasoning
Blast-radius summary
Deterministic triage is authoritative; any optional LLM explanation cannot change the verdict. |
VIVAAN-DHAWAN
force-pushed
the
fix/setup-double-update-check
branch
from
August 23, 2026 05:20
e91851c to
57d54ee
Compare
main() ran _check_and_prompt_update for the setup command, and the setup walkthrough then launches the wizard, which performs its own check — so users with a pending release faced the same prompt two times in a row. Exclude setup like update/version/help/doctor and let the wizard own the check.
VIVAAN-DHAWAN
force-pushed
the
fix/setup-double-update-check
branch
from
August 23, 2026 05:57
57d54ee to
92d9df4
Compare
VIVAAN-DHAWAN
changed the base branch from
main
to
fix/raw-fd-keystroke-reading
August 23, 2026 05:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
diffly setupperforms the PyPI update check twice.main()runs_check_and_prompt_update()for every command exceptupdate/version/help/doctor— andsetupis not excluded, even though the walkthrough ends by launching the wizard (run_setup→run_wizard), which runs its own check at cli.py:762. With a release pending, the user gets the same "Download and install?" prompt two times back-to-back (declining the first does not suppress the second).What users will see / Surface area
src/diffly_cli/cli.py::main:setupjoins the exclusion list; the wizard remains the single owner of the update check for that flow.pr,local, bare wizard).Validation
test_setup_delegates_the_update_check_to_the_wizard: asserts zero checks fire fordiffly setup(the wizard owns it) whilediffly pr …still fires exactly one.pytest -q→ 54 passed.