tech: add vkui-nextjs-ts example
#8404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
👀 Docs deployed
Commit d12705e |
e2e tests
|
inomdzhon
reviewed
Mar 28, 2025
inomdzhon
reviewed
Mar 31, 2025
inomdzhon
previously approved these changes
Mar 31, 2025
vkcom-publisher
added
the
pr-needs-work
BlackySoul
added
no-stale
BlackySoul
reviewed
Apr 9, 2025
| <html lang="ru" suppressHydrationWarning> | ||
| <head> | ||
| <title>NextJS + VKUI + TS</title> | ||
| <meta |
There was a problem hiding this comment.
nextjs форсит задавать метатэги через объект, иначе дубли будут, в данном случае вот это лучше заюзать?
BlackySoul
reviewed
Apr 9, 2025
| <Flex direction="column" justify="center" className={styles.layout}> | ||
| <FixedLayout vertical="top"> | ||
| <Flex justify="end" className={styles.header}> | ||
| <Flex.Item>{colorSchemeSwitcher}</Flex.Item> |
There was a problem hiding this comment.
Suggested change
| <Flex.Item>{colorSchemeSwitcher}</Flex.Item> | |
| {colorSchemeSwitcher} |
BlackySoul
reviewed
Apr 9, 2025
| }; | ||
|
|
||
| export const useColorSchemeSwitcher = (): [ColorSchemeType, React.ReactNode] => { | ||
| const defaultColorScheme = useColorScheme(); |
There was a problem hiding this comment.
А зачем этот хук тут юзать? Сейчас в шаблоне получается сломано автоопределение темы (потому что мы всегда будем форсить светлую)
There was a problem hiding this comment.
Да, ошибся здесь. Поправил - добавил отдельную обертку с ColorSchemeProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Необходимо добавить шаблон для приложения с использованием
Next js + VKUI + TypeScript, чтобы пользователям было удобнее начинать использоватьVKUIИзменения
Next js + VKUI + TypeScriptс небольшой версткой и возможностью изменения цветовой схемы приложенияПроект можно глянуть через CodeSandbox
Release notes
Документация
Next js + VKUI + TypeScript