Merged
Conversation
* Update revision for JavaScriptCore * Remove `webkit.patch`
If the LiveTests generate endless loops and the test's timeout mechanism doesn't terminate it, the action can run for multiple hours. Change-Id: I20d40fcb95d8c526320db3439624cf4d7079ef78 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8633202 Auto-Submit: Matthias Liedtke <mliedtke@google.com> Commit-Queue: Matthias Liedtke <mliedtke@google.com> Reviewed-by: Danylo Mocherniuk <mdanylo@google.com>
Change-Id: I89b0829edfb72d72e22b9dc4e41862b76a8db711 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8637337 Commit-Queue: Matthias Liedtke <mliedtke@google.com> Reviewed-by: Danylo Mocherniuk <mdanylo@google.com> Auto-Submit: Matthias Liedtke <mliedtke@google.com>
Change-Id: I2c2f574e7c99948b70d86212c5daa8cdd083692a Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8635657 Reviewed-by: Danylo Mocherniuk <mdanylo@google.com> Commit-Queue: Matthias Liedtke <mliedtke@google.com>
Right now the MacOS job is broken. That doesn't mean that we don't care about the results of the linux job any more. In an ideal world, all jobs would be green. Right now this is simply not the case, so we should provide the best possible information. Change-Id: Ifb107d8ed6b9c116e5c151293dd10bf38dc90c95 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8643676 Commit-Queue: Danylo Mocherniuk <mdanylo@google.com> Auto-Submit: Matthias Liedtke <mliedtke@google.com> Reviewed-by: Danylo Mocherniuk <mdanylo@google.com> Commit-Queue: Matthias Liedtke <mliedtke@google.com>
Previously we had ProgramBuilder.buildRecursive() to recursively generate code into a program which was replaced with ProgramBuilder.build() calls with the new code generation mechanism. However the default BuildingMode is .generatingAndSplicing which now rerolls a die on each build(n: x) call in a code generator whether to generate or splice which significantly increases the amount of splicing done by Fuzzilli. As splicing is very expensive and involves rewriting the whole program, we should not randomly splice when running CodeGenerators. For ProgramTemplates (similarly to before) each build call still rolls a die whether to generate or splice (however, when deciding to generate on a build() call, this decision will then "stick" as code generators will be using .generating in all cases now. Bug: 448862171 Change-Id: I982c0f992994d2592de43b71c2b59f3dd334e2bb Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8637338 Commit-Queue: Matthias Liedtke <mliedtke@google.com> Reviewed-by: Carl Smith <cffsmith@google.com>
Commit adfa084 manually modified the program.proto, so these got out of sync. Bug: 446634535 Change-Id: I63438de9d88684a766b2f4f2cfc7f88a5b5b1079 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8643678 Reviewed-by: Michael Achenbach <machenbach@google.com> Auto-Submit: Matthias Liedtke <mliedtke@google.com> Commit-Queue: Michael Achenbach <machenbach@google.com>
… methods Bug: 446634535 Change-Id: I9c2e556efcbc6288e5cc92baca471b4ac1482797 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8636358 Commit-Queue: Michael Achenbach <machenbach@google.com> Reviewed-by: Matthias Liedtke <mliedtke@google.com>
Also canonically hide the intermediate variable used for "Symbol" as done in some of the existing use cases. Bug: 446634535 Change-Id: I00794d4120057ef7e096ca913f827f8872d6ce41 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8646836 Reviewed-by: Matthias Liedtke <mliedtke@google.com> Commit-Queue: Michael Achenbach <machenbach@google.com>
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To look at: Splicing changed at 2107b72
The GitHub Actions changes should be fine, but they're using to https://github.com/GoogleChromeLabs/jsvu to test more.
They're also testing on release + stopping macos crashing from crashing everything.