Fix d and D in VisualBlock mode with multiple cursors. Fixes #4683.

Author: J-Fields

src/actions/commands/actions.ts

@@ -692,9 +692,6 @@ class CommandDeleteToLineEnd extends BaseCommand {
   modes = [Mode.Normal];
   keys = ['D'];
   override createsUndoPoint = true;
-  override runsOnceForEveryCursor() {
-    return true;
-  }
 
   public override async exec(position: Position, vimState: VimState): Promise<void> {
     if (position.isLineEnd(vimState.document)) {
@@ -1476,9 +1473,6 @@ class ActionDeleteVisualBlock extends BaseCommand {
   modes = [Mode.VisualBlock];
   keys = [['d'], ['x'], ['X']];
   override createsUndoPoint = true;
-  override runsOnceForEveryCursor() {
-    return false;
-  }
 
   public override async exec(position: Position, vimState: VimState): Promise<void> {
     const lines: string[] = [];
@@ -1511,9 +1505,6 @@ class ActionShiftDVisualBlock extends BaseCommand {
   modes = [Mode.VisualBlock];
   keys = ['D'];
   override createsUndoPoint = true;
-  override runsOnceForEveryCursor() {
-    return false;
-  }
 
   public override async exec(position: Position, vimState: VimState): Promise<void> {
     const lines: string[] = [];

test/multicursor.test.ts

@@ -69,6 +69,26 @@ suite('Multicursor', () => {
     });
   });
 
+  suite('Delete', () => {
+    newTest({
+      title: 'x (Normal mode)',
+      start: ['|cat', 'c|at', 'ca|t'],
+      keysPressed: 'x',
+      end: ['|at', 'c|t', 'c|a'],
+    });
+
+    // TODO: `D`
+
+    newTest({
+      title: 'd (Visual mode)',
+      start: ['|cat', 'c|at', 'ca|t'],
+      keysPressed: 'vl' + 'd',
+      end: ['|t', '|c', 'c|a'],
+    });
+
+    // TODO: VisualBlock mode
+  });
+
   suite('Replace', () => {
     newTest({
       title: 'r (Normal mode)',