Skip to content

Conversation

@evaleev
Copy link
Member

@evaleev evaleev commented Feb 6, 2026

No description provided.

@evaleev evaleev force-pushed the evaleev/feature/tapp-interpreter branch from 9b34e73 to 5a4d051 Compare February 6, 2026 18:32
@evaleev evaleev force-pushed the evaleev/feature/tapp-interpreter branch from 5a4d051 to b41cd96 Compare February 6, 2026 18:38
@evaleev evaleev requested a review from Copilot February 6, 2026 21:06
@evaleev evaleev added this to the 2.1 milestone Feb 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new TAPP-based evaluation backend for SeQuant, wiring it into the build system and adding both unit and integration coverage to validate correctness against manual contractions/permutations and SCF integration behavior.

Changes:

  • Add a header-only TAPP backend (TAPPTensor, ops, Result integration, EvalExpr integration) and MBPT biorthogonal cleanup support for TAPP tensors.
  • Add unit + integration tests for the TAPP backend, and hook them into the test CMake targets conditionally on SEQUANT_HAS_TAPP.
  • Extend CMake packaging/build to find or fetch the tapp-reference dependency; update external dependency pins; fix a BTAS unit test assertion.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tests/unit/test_eval_tapp.cpp New unit tests validating TAPP evaluation, symm/antisymm, and biorthogonal cleanup behaviors.
tests/unit/test_eval_btas.cpp Fixes an incorrect assertion and strengthens the comparison between two evaluation paths.
tests/unit/CMakeLists.txt Adds conditional compilation/linkage of the new TAPP unit test object library.
tests/integration/eval/tapp/data_world_tapp.hpp Provides TAPP-backed data world for integration SCF tests (mirrors BTAS version).
tests/integration/eval/tapp/scf_tapp.hpp Implements SCF driver using TAPP backend evaluation (mirrors BTAS version).
tests/integration/eval/tapp/main.cpp Integration test entry point for TAPP SCF run and energy check.
tests/integration/eval/CMakeLists.txt Adds conditional eval_tapp integration executable and ctest entry.
SeQuant/core/eval/backends/tapp/tensor.hpp Introduces TAPPTensor container bridging to the TAPP C API tensor-info handle.
SeQuant/core/eval/backends/tapp/ops.hpp Implements TAPP-based contract/permute/scal/dot ops used by the Result backend and tests.
SeQuant/core/eval/backends/tapp/eval_expr.hpp Adds TAPP-specific EvalExpr with TAPP-compatible annotation.
SeQuant/core/eval/backends/tapp/result.hpp Implements ResultTensorTAPP integration (sum/prod/permute/symm/antisymm).
SeQuant/domain/mbpt/biorthogonalization.hpp Adds TAPP overload for biorthogonal_nns_project.
cmake/modules/FindOrFetchTAPP.cmake New module to find or FetchContent the TAPP reference implementation and patch/install targets.
cmake/modules/FindOrFetchBTAS.cmake Fixes BTAS tag variable name used for FetchContent.
cmake/sequant-config.cmake.in Extends installed package config to locate tapp-reference when not built from source.
external/versions.cmake Updates pinned dependency tags and adds BTAS/TAPP tracked tags.
CMakeLists.txt Adds SEQUANT_TAPP option, builds SeQuant::eval::tapp target, and wires export/module lists.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@evaleev evaleev force-pushed the evaleev/feature/tapp-interpreter branch 4 times, most recently from 41be0b9 to 032a5c1 Compare February 7, 2026 03:29
@evaleev evaleev force-pushed the evaleev/feature/tapp-interpreter branch from 032a5c1 to 6241cb2 Compare February 7, 2026 04:43
@evaleev evaleev merged commit dd25c1c into master Feb 7, 2026
16 checks passed
@evaleev evaleev deleted the evaleev/feature/tapp-interpreter branch February 7, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant