feat: Add macOS development support#467
Merged
MSchmoecker merged 3 commits intoValheim-Modding:devfrom Jan 18, 2026
Merged
Conversation
Contributor
jneb802
commented
Jan 15, 2026
jneb802
commented
- Add VALHEIM_MANAGED variable to Paths.props with OS-agnostic defaults
- Replace hardcoded Windows paths in JotunnLibRefsCorlib.props with variable references
- Use forward slashes for cross-platform compatibility
- Support Environment.props import for local path overrides
- Remove VALHEIM_MANAGED override from JotunnLib.csproj
- Add VALHEIM_MANAGED variable to Paths.props with OS-agnostic defaults - Replace hardcoded Windows paths in JotunnLibRefsCorlib.props with variable references - Use forward slashes for cross-platform compatibility - Support Environment.props import for local path overrides - Remove VALHEIM_MANAGED override from JotunnLib.csproj
MSchmoecker
reviewed
Jan 15, 2026
JotunnLib/BuildProps/Paths.props
Outdated
| <BEPINEX_PATH>$(VALHEIM_INSTALL)\BepInEx</BEPINEX_PATH> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="$(VALHEIM_MANAGED)=='' AND $(VALHEIM_INSTALL) != ''"> | ||
| <VALHEIM_MANAGED>$(VALHEIM_INSTALL)/valheim_Data/Managed</VALHEIM_MANAGED> |
Member
There was a problem hiding this comment.
It should be Valheim_Data/Managed here. Maybe both paths can be added with an Exists condition, in case someone has an old folder or Valheim changes it back
Contributor
Author
There was a problem hiding this comment.
@MSchmoecker Good point, addressed that in:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.