[TF2] Fix high melee firing speed not working correctly #1574
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naydef
changed the title
ficool2
reviewed
Oct 24, 2025
| m_flSmackTime = GetSmackTime( m_iWeaponMode ); | ||
| if(m_flSmackTime >= m_flNextPrimaryAttack) | ||
| { | ||
| m_flSmackTime = m_flNextPrimaryAttack - 0.01; |
There was a problem hiding this comment.
Not only can this be problematic with float resolution, it won't work correctly on servers running higher tickrates (like 100)
An alternative approach to this whole PR which I suggest you try, is to run Smack() if smacktime >= primaryattacktime when the player tries attacking again
There was a problem hiding this comment.
Yea, I knew this is not the best approach. I'll try your idea and report back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ValveSoftware/Source-1-Games#6223
I'm a bit concerned if this fix will be working correctly if
m_flNextPrimaryAttackbecomes too high (loss of resolution).Maybe it does not matter...
Suggestions welcomed