[TF2] Allow HWM models and VCDs to be enabled #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It's disabled because Valve ceased to make a separate set of VCD for HWM models to support newer taunts so it's broken anyway. |
Contributor
|
The efficient shaders for HWM are disabled in the engine as support was dropped ( The HWM materials are also missing properties like to handle Jarate I do not see any reason why you should use HWM ingame, the higher quality morphing is not noticeable. The only significant difference would be wrinklemaps but those can be made to work on non HWM too |
Contributor
|
An additional reason is that skin cosmetic items don't go well with HWM models, as demonstrated with the Burly Beast (HWM on the left, regular on the right taken from the TF Wiki): 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alongside its set of usual playermodels, TF2 includes a set of hardware morph (HWM) playermodels that use a more advanced set of facial flexes than their regular counterparts. Previously, the use of HWM models and their facial flexes could be controlled with the variables
mp_usehwmmodelsandmp_usehwmvcdsrespectively. However, at some point in TF2's lifetime, the code for these commands was commented out, forcibly disabling HWM on all PCs regardless of these variables' values.As this PR's existence likely suggests, I don't know why this change was made.
This PR uncomments the code for the commands
mp_usehwmmodelsandmp_usehwmvcds, once again allowing players to use HWM by setting their values to 1. In order to preserve the current behavior of not using HWM by default, this PR also changes both variables' default values to -1.This resolves ValveSoftware/Source-1-Games#4751.