Skip to content

[ADD] 12.0-connector_magento_multi_source_inventory - #18

Open
MPishpecki wants to merge 2 commits into
12.0from
12.0-connector_magento_multi_source_inventory
Open

[ADD] 12.0-connector_magento_multi_source_inventory#18
MPishpecki wants to merge 2 commits into
12.0from
12.0-connector_magento_multi_source_inventory

Conversation

@MPishpecki

Copy link
Copy Markdown

No description provided.

@MPishpecki

Copy link
Copy Markdown
Author

@StefanRijnhart Please have a look. This is WIP. Importer is working. I could not get the exporter working. If you run the tests you will see where it fails. I don't get why it fails - which is the worst thing. the whole connector_magento_multi_source_inventory/models/magento_source/stock_exporter.py file is copied and changes exporter for the stock picking or move - the example you sent. Almost all code needs to be removed except for the run().
A more concrete example would help or if you can push a working exporter - that would be great.

the Magento ID, the ID of the Magento Backend and the additional
fields belonging to the Magento instance.
"""
_name = 'magento.binder'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure you are not supposed to list all known apply_ons below. Would it work if you leave out _name here, inherit from 'magento.binder' instead and just set _apply_on = 'magento.source'?


@api.multi
def synchronize_metadata(self):
# super(MagentoBackend, self).synchronize_metadata()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is WIP but when you say tests break, not calling super is not going to help.

binding.name)

self._validate(binding)
self._check_allowed_carrier(binding, external_id)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could remove all this carrier related stuff first, to make it more clear (I can imagine this also makes the tests fail).

@MPishpecki

Copy link
Copy Markdown
Author

Stefan, just a heads up. I stopped developing this. I may do some work later when I there is no load in 8.

@StefanRijnhart

Copy link
Copy Markdown

Agreed, that's why I have already merged the custom module instead.

@MPishpecki

Copy link
Copy Markdown
Author

Closing PR - too old

@MPishpecki MPishpecki closed this Sep 5, 2022
@MPishpecki MPishpecki reopened this Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants