Skip to content

[FIX] #OD-1824: Capture magento queue job erros - #21

Open
Soukainaalhaddan wants to merge 2 commits into
12.0from
OD-1824-queue-job-followup-magento-errors-not-always-captured-clearly
Open

[FIX] #OD-1824: Capture magento queue job erros#21
Soukainaalhaddan wants to merge 2 commits into
12.0from
OD-1824-queue-job-followup-magento-errors-not-always-captured-clearly

Conversation

@Soukainaalhaddan

@Soukainaalhaddan Soukainaalhaddan commented Mar 3, 2022

Copy link
Copy Markdown

Capture Magento queue job errors.

  • Check for response and handle the response body.
  • In case of no response found, raise the error handled by raise_for_status()

Comment thread connector_magento/components/backend_adapter.py Outdated
Comment thread connector_magento/components/backend_adapter.py Outdated
Comment thread connector_magento/components/backend_adapter.py Outdated
Comment thread connector_magento/components/backend_adapter.py
Comment thread connector_magento/components/backend_adapter.py Outdated
Comment thread connector_magento/exception.py Outdated
@StefanRijnhart

Copy link
Copy Markdown

Thanks for the updates! Looking good now. We now need to get the buildout PR (https://github.com/VanMoof/odoo-buildout/pull/394) green.

@Soukainaalhaddan
Soukainaalhaddan force-pushed the OD-1824-queue-job-followup-magento-errors-not-always-captured-clearly branch from 0c13fab to 7d01f7b Compare March 17, 2022 11:56
Comment thread connector_magento/components/backend_adapter.py
@Soukainaalhaddan
Soukainaalhaddan force-pushed the OD-1824-queue-job-followup-magento-errors-not-always-captured-clearly branch 2 times, most recently from b036b01 to 75f882e Compare March 17, 2022 16:30
[FIX] Capture magento queue job erros

fix code and handle json error

remove repeated code lines
@Soukainaalhaddan
Soukainaalhaddan force-pushed the OD-1824-queue-job-followup-magento-errors-not-always-captured-clearly branch from 75f882e to 3c3b14a Compare March 17, 2022 16:35
@Soukainaalhaddan Soukainaalhaddan changed the title [FIX] Capture magento queue job erros [FIX] #OD-1824: Capture magento queue job erros Mar 18, 2022

@StefanRijnhart StefanRijnhart left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

…ns a valid json (#23)

* [FIX] OD-1976: Treat Simplejson errors

* [FIX] OD-1976: improve code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants