[FIX] stock_move_manual_lot: action_assing based on stock_move.write_…

stock_move_manual_lot/models/stock_move_line.py

@@ -1,7 +1,6 @@
 # Copyright 2021 Hunki Enterprises BV
 # Copyright 2021 Opener B.V. <stefan@opener.amsterdam>
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
-import operator
 from odoo import _, api, fields, models
 from odoo.exceptions import UserError
 from odoo.tools.float_utils import float_compare
@@ -19,13 +18,33 @@ class StockMoveLine(models.Model):
         copy=False,
     )
 
+    def _store_product_qty(self):
+        """Ensure consistent values for product_qty in the database
+
+        This module triggers (re)assignment of affected pickings within a
+        x2many write on a picking's move lines. The quantity to assign depends
+        on stock.move's reserved_quantity, which depends on the recompute of
+        stock.move.line's `product_qty` whenever `product_uom_quantity is
+        written. Because the x2many commands are processed under the scope of
+        env.norecompute(), we have to take care of this ourselves.
+        """
+        field = self._fields["product_qty"]
+        mls = self.env.field_todo(field).exists()
+        for ml in mls:
+            ml._write({"product_qty": ml.product_qty})
+        self.env.remove_todo(field, mls)
+
     @api.multi
     def unlink(self):
         """Keep move lines if they are assigned a manual lot in a batch"""
         if self.env.context.get("manual_lot_move_lines"):
             to_keep = self.filtered(
                 lambda ml: ml.id in self.env.context["manual_lot_move_lines"])
-            to_keep.write({"product_uom_qty": 0, "lot_id": False})
+            to_keep.write({
+                "lot_id": False,
+                "manual_lot_id": False,
+                "product_uom_qty": 0,
+            })
             self -= to_keep
         if not self:
             return True
@@ -51,12 +70,16 @@ def create(self, vals_list):
                     else:
                         to_super.append(vals)
         result += super().create(to_super)
+        if not self.env.recompute:
+            self._store_product_qty()
         for vals, this in zip(vals_list, result):
             this._reserve_manual_lot(vals)
         return result
 
     def write(self, vals):
         result = super().write(vals)
+        if "product_uom_qty" in vals and not self.env.recompute:
+            self._store_product_qty()
         self._reserve_manual_lot(vals)
         return result
 
@@ -110,11 +133,9 @@ def _reserve_manual_lot(self, vals):
                     ml_to_ignore=self,
                 )
                 self.env.cr.execute(
-                    'select id from stock_picking where write_date = %s', (now,),
+                    'select distinct picking_id from stock_move where write_date = %s', (now,),
                 )
-                updated_picking_ids = list(map(
-                    operator.itemgetter(0), self.env.cr.fetchall(),
-                ))
+                updated_picking_ids = [row for row, in self.env.cr.fetchall() if row]
 
             this.lot_id = this.manual_lot_id
             if this.product_qty < product_qty: