[MIG] 12.0-claim_from_delivery - #4
Conversation
|
After long time struggling I as able only to add a module without history |
|
I will add test here. |
| "author": "Vanmoof BV, OpenERP SA", | ||
| "category": "Warehouse Management", | ||
| "depends": ["base", "crm_claim", "stock"], | ||
| "license": "AGPL-3", |
There was a problem hiding this comment.
Odoo 9.0 was already relicensed as LGPL-3 so we need to go with that.
| { | ||
| "name": "Claim on Deliveries", | ||
| "version": "12.0.1.0.0", | ||
| "author": "Vanmoof BV, OpenERP SA", |
There was a problem hiding this comment.
In order of appearance ;-)
OpenERP SA,Vanmoof BV,Odoo Community Association (OCA)
| @@ -0,0 +1,4 @@ | |||
| * Stefan Rijnhart <stefan@opener.amsterdam> (https://opener.amsterdam) | |||
There was a problem hiding this comment.
I didn't do anything! You can remove me from this bit
There was a problem hiding this comment.
Would be nice if you could list the committers on the module from the Odoo tree though.
There was a problem hiding this comment.
CREDITS.rst is an empty file below, so Github won't let me comment on it, but can you add the disclaimer from OCA/crm@8078fc9#diff-7a2d2e4fa90e6191ec005372e4b17018R47-R49?
| @@ -0,0 +1,16 @@ | |||
| # © 2020 Vanmoof BV (<https://www.vanmoof.com>) | |||
| # © 2004-2009 Tiny SPRL (<http://tiny.be>) | |||
There was a problem hiding this comment.
To be precise, I see code changes up until 2015 in odoo/9.0, and Tiny SPRL is currently Odoo SA
| "version": "12.0.1.0.0", | ||
| "author": "Vanmoof BV, OpenERP SA", | ||
| "category": "Warehouse Management", | ||
| "depends": ["base", "crm_claim", "stock"], |
| <?xml version="1.0"?> | ||
| <odoo> | ||
|
|
||
| <record model="res.request.link" id="request_link_claim_from_delivery"> |
There was a problem hiding this comment.
Obsolete file (you already removed it from the manifest file.
| class StockPicking(models.Model): | ||
| _inherit = 'stock.picking' | ||
|
|
||
| @api.model |
| @api.model | ||
| def _claim_count_out(self): | ||
| """ | ||
| Count number of calims ralted to stock pickings |
| def _claim_count_out(self): | ||
| """ | ||
| Count number of calims ralted to stock pickings | ||
| :return: dict( picking.id: number of claims) |
There was a problem hiding this comment.
No return value in this version anymore
| [('model_ref_id', '=', 'stock.picking,{}'.format(pick.id))]) | ||
|
|
||
| claim_count_out = fields.Integer( | ||
| compute="_claim_count_out", string="Claims") |
There was a problem hiding this comment.
See https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#models (and maybe it's good to reread this whole document): the compute method pattern is _compute_<field_name>
|
Did I get all of the comments? |
1b35c88 to
765f648
Compare
2 participants
No description provided.