VanMoof customisation - #9
Closed
astirpe wants to merge 5 commits into
Closed
Conversation
When the manual lot is assigned to multiple lines on the same picking at once,
it can be the case that some lots are reassigned between these lines. In this
case we have to prevent those lines from being deleted when they are being
unreserved, otherwise when they receive their manual lot in their turn, they
no longer exist ("Record does not exist or has been deleted").
In this change, we determine beforehand to which move lines this is likely
to happen and prevent their deletion (once in the move line's unlink method,
and once in the stock move's _do_unreserve method). When the move is being
rereserved later in the same call, these zero qty move lines are reused.
…backorder (#7) * [FIX] Don't throw 'unreserve more than in stock' error when creating backorder * [FIX] Don't unreserve when unsetting the manual lot * [IMP] Usability in the case of non tracked products or configuration change Keep visibility of the transferred lots for non tracked products or products transferred before the picking type was configured for manual lot selection. * Update stock_move_manual_lot/models/stock_move_line.py Co-authored-by: Holger Brunn <mail@hunki-enterprises.com> Co-authored-by: Holger Brunn <mail@hunki-enterprises.com>
MPishpecki
approved these changes
Sep 29, 2021
|
Replaced by #12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a container of all the VanMoof customisations regarding stock-logistics-workflow