Fix/price candles webhook dispatch readme env#462
Merged
Mimah97 merged 4 commits intoJun 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Closes #365
closes #366
closes #367
closes #368
FILES CHANGED:
What was implemented:
Price controller spec against real candles (price.controller.spec.ts): The mockCandle fixture was misaligned with the actual PriceCandle interface exported by price.service.ts. It used timestamp (wrong field name) and string OHLCV values — but the real interface uses time: number and numeric open/high/low/close/volume. Fixed to match exactly: { time: 1700000000, open: 0.09, high: 0.11, low: 0.08, close: 0.1, volume: 50000 }.
Webhooks dispatch integration test (webhook.processor.spec.ts): Created a new spec covering the full WebhookWorker dispatch pipeline — both the queue-enqueue layer (dispatch()) and the HTTP-delivery layer (deliver()). Tests cover: correct job options (3 attempts, exponential backoff), HMAC-SHA256 signature attachment when a secret is set, delivery log recording, consecutiveFails increment/reset logic, auto-disable after 10 consecutive failures, and graceful handling of network errors (ECONNREFUSED → undefined status). Worker is instantiated directly (bypassing onModuleInit) to avoid real Redis/BullMQ connections in CI.
Fix README org links to vatix-protocol (README.md): Two GitHub URLs in the README pointed at the old Valreb001 org. Both updated to vatix-protocol: the git clone command and the "good first issue" label filter link.
Add STELLAR_RPC_URL to web .env.example (apps/web/.env.example): The API's .env.example already had STELLAR_RPC_URL, but the web app's .env.example was missing it. Added NEXT_PUBLIC_STELLAR_RPC_URL=https://soroban-testnet.stellar.org so the SDK can reach Soroban RPC directly from the browser.
Type of change
Checklist