Open
Conversation
Contributor
|
could you elaborate the commit and mr description showing up why it's an infinite loop lead_processing please? Regards! |
Contributor
Author
Sure, I've updated the description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix an infinite loop that happens when there are multiple pages in in the lead information from facebook.
The
ifstatement checks if there are more pages so it changes thedatavariable with the information corresponding to the next page. In this case, as theresponsevariable is never updated or reused, it keeps loading only the second page of the facebook leads every time, which leads to an infinite loop that never ends as it will always enter theifstatement reaching no end.