Fix log filtering#11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the log filtering functionality by ensuring that a logging handler exists before attempting to add a filter to it. The fix prevents potential errors when trying to apply the IgnoreOpenAI401Filter to an empty handler list.
- Adds a check for existing handlers before applying the filter
- Initializes basic logging configuration if no handlers are present
Comments suppressed due to low confidence (1)
src/utils/logging.py:29
- The new handler existence check and basicConfig initialization should be covered by tests to ensure the fix works correctly in scenarios where no handlers are initially present.
if not root_logger.handlers:
aishwaryapb
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Fix
Short Description
Make sure a handler exists so that the log filtering function can be added to the handler.
Tests Added
N/A