Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
Short Description
Reduces RAM usage by the retrieval pipeline by:
mmlearn/modules/metrics/retrieval_recall.py
in batches instead of all at once.MetricCollection
inmmlearn/tasks/zero_shot_retrieval.py
for all modality-pairs to avoid duplicate tensors creations.TODOs:
retrieval_recall.py
andzero_shot_retrieval.py
without providing an option to use the previous implementation. This option needs to be added.Tests Added
You can run retrieval by:
However, W&B does not log RAM usage during recall@k calculation. You need to manually add logging lines and compare RAM usage of this implementation vs. the previous one.