Skip to content

Fixes Colab issue and updates aieng-rag-utils module #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aishwaryapb
Copy link
Collaborator

Changes

  1. The notebooks were not running on Google Colab due to dependency conflicts on Colab environment. This fixes the issue by re-installing specific versions of the packages and uninstalling unnecessary conflicting packages.\
  2. Updated Colab links to point to main branch on GitHub.
  3. aieng-rag-utils package did not reflect the correct list of dependencies. Updated the list and changed the version from a pre-release one to release - v1.0.0

@aishwaryapb aishwaryapb requested review from amrit110 and Copilot June 26, 2025 17:14
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issues with dependency conflicts on Google Colab and updates the aieng-rag-utils module version and dependency list. Key changes include:

  • Reinstalling specific package versions and uninstalling conflicting dependencies in all implementation notebooks.
  • Updating Colab badge links to always reference the main branch.
  • Bumping aieng-rag-utils module from a pre-release version to release v1.0.0 and adjusting its dependency list.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

File Description
pyproject.toml Removed unneeded dependencies from the main project configuration.
implementations//.ipynb Updated Colab links, added installation commands with fixed version pinning, and introduced uninstall steps for conflicting packages.
aieng-rag-utils/pyproject.toml Updated version to v1.0.0 and added dependencies previously removed from the main pyproject.toml.
.github/workflows/publish.yml Removed the GitHub release creation step.
Comments suppressed due to low confidence (11)

implementations/web_search/web_search_llamaindex.ipynb:59

  • The uninstall command includes 'torchao', which appears to be a typo; please verify whether it should be 'torch' or if this entry is intentional.
    "    !pip3 uninstall --yes torchao torchaudio torchdata torchsummary torchtune"

implementations/web_search/web_search_langchain.ipynb:58

  • The uninstall command lists 'torchao', which seems unusual; please confirm if this is a typographical error.
    "    !pip3 uninstall --yes torchao torchaudio torchdata torchsummary torchtune\n"

implementations/sql_search/sql_search_langchain.ipynb:63

  • The uninstallation command includes 'torchao', which is likely a typo; please verify the intended package name.
    "    !pip3 uninstall --yes torchao torchaudio torchdata torchsummary torchtune"

implementations/rag_evaluation/rag_evaluation_testset_generation.ipynb:58

  • The uninstall command for conflicting dependencies contains 'torchao', which may be a typo; please check if it should be 'torch'.
    "    !pip3 uninstall --yes torchao torchaudio torchdata torchsummary torchtune"

implementations/rag_evaluation/rag_evaluation_basic.ipynb:64

  • The pip uninstall command includes 'torchao', which appears to be an error; please verify if this should be corrected.
    "    !pip3 uninstall --yes torchao torchaudio torchdata torchsummary torchtune"

implementations/pubmed_qa/pubmed_qa_llamaindex.ipynb:59

  • The uninstall command lists 'torchao', which is potentially a typographical error; confirm if it should be updated.
    "    !pip3 uninstall --yes torchao torchaudio torchdata torchsummary torchtune"

implementations/document_search/document_search_llamaindex_cohere.ipynb:58

  • The uninstallation command includes 'torchao' which may be a typo; please verify the correct package name.
    "    !pip3 uninstall --yes torchao torchaudio torchdata torchsummary torchtune"

implementations/document_search/document_search_llamaindex.ipynb:58

  • The uninstall command contains 'torchao', which appears to be incorrect; please check if it should be 'torch'.
    "    !pip3 uninstall --yes torchao torchaudio torchdata torchsummary torchtune"

implementations/document_search/document_search_langchain_cohere.ipynb:58

  • The uninstallation step includes 'torchao' which might be a typo; please verify this dependency.
    "    !pip3 uninstall --yes torchao torchaudio torchdata torchsummary torchtune"

implementations/document_search/document_search_langchain.ipynb:58

  • The pip uninstall command lists 'torchao', which appears to be a misspelling; please confirm and update accordingly.
    "    !pip3 uninstall --yes torchao torchaudio torchdata torchsummary torchtune"

implementations/cloud_search/s3_search_llamaindex.ipynb:64

  • The uninstall command includes 'torchao', which is likely a typo; please review whether the intended target is 'torch' or another package.
    "    !pip3 uninstall --yes torchao torchaudio torchdata torchsummary torchtune"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant