feat(guruswami-sudan): constructive decoder witness/filter correctness#311
feat(guruswami-sudan): constructive decoder witness/filter correctness#311eliasjudin wants to merge 20 commits intoVerified-zkEVM:mainfrom
Conversation
Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
🤖 Gemini PR SummaryGuruswami-Sudan Implementation
Refactoring and API Changes
Proof Status and Technical Debt
Infrastructure and CI
Statistics
Lean Declarations ✏️ **Removed:** 15 declaration(s)
✏️ **Added:** 58 declaration(s)
✏️ **Affected:** 5 declaration(s) (line number changed)
✅ **Removed:** 4 `sorry`(s)
❌ **Added:** 4 `sorry`(s)
✏️ **Affected:** 2 `sorry`(s) (line number changed)
🎨 **Style Guide Adherence**The following violations were identified in the reviewed changes (23 violations total, grouped by rule): Rule: Functions and Terms must be
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abf6a7f5d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
71db7ac to
3fde0b1
Compare
cedd967 to
5a97ec0
Compare
5a97ec0 to
8aa5bfb
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8aa5bfba09
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
You can use |
this is actually exactly what was needed for the computable definition, will update later |
1a82b33 to
a23a779
Compare
Resolve the and sorries by reusing existing Guruswami-Sudan existence/divisibility results with the required hypotheses and aligned condition types. Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
…4-pr300-followup Follow-up: prove BCIKS20 proximity-gap existence/property lemmas
67686cf to
8738954
Compare
|
still trying to write a constructive algorithm for computing a Guruswami–Sudan witness |
|
@quangvdao @dhsorens some of this should probably go into CompPoly. let me know if you have any suggestions. |
…guruswami-sudan-prop
Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
862dd94 to
db2b88f
Compare
|
Thanks for the PR! I'd like to merge #300 and then this one on top of it if you could keep an eye out for that and facilitate this. |
@alexanderlhicks I'll wait for that and then update! Leaving the proximity generators stuff to @katyhr |
37b97c8 to
1fa0001
Compare
This PR adds proofs autoformalised by @Aristotle-Harmonic.
Implements constructive Guruswami-Sudan witness extraction in
computeGsWitnessvia a normalized linear system solved byBerlekampWelch.linsolve, removing the brute-force fallback from the decoder path. It checks multiplicity by Hasse-derivative vanishing and performs computable CompPoly root filtering (Q(X, p(X)) = 0), with decoder soundness captured bydecoder_mem_impl_dist; closes #213.Co-authored-by: Aristotle (Harmonic) aristotle-harmonic@harmonic.fun