fix(proximity-gap): resolve AHIV22 proof obligations (#226 #227 #234)#385
Draft
eliasjudin wants to merge 3 commits intoVerified-zkEVM:mainfrom
Draft
fix(proximity-gap): resolve AHIV22 proof obligations (#226 #227 #234)#385eliasjudin wants to merge 3 commits intoVerified-zkEVM:mainfrom
eliasjudin wants to merge 3 commits intoVerified-zkEVM:mainfrom
Conversation
🤖 Gemini PR SummaryCompletes the formalization of key proximity gap results from the AHIV22 paper, specifically targeting combinatorial and probabilistic bounds for Reed-Solomon proximity tests. Mathematical Formalization
Proof Completion
Refactoring & Infrastructure
Statistics
Lean Declarations ✏️ **Removed:** 3 declaration(s)
✏️ **Added:** 7 declaration(s)
✏️ **Affected:** 2 declaration(s) (line number changed)
✅ **Removed:** 3 `sorry`(s)
🎨 **Style Guide Adherence**There are more than 20 style guide violations in the provided diff. They are grouped by rule below:
📄 **Per-File Summaries**
Last updated: 2026-03-08 10:51 UTC. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a99ad53d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+1436
to
+1437
| (∀ x ∈ Affine.affineLineAtOrigin (F := F) u v, Δ₀(x, ReedSolomon.code α deg) ≤ e) | ||
| ∨ numberOfClosePts u v deg α e ≤ ‖(RScodeSet α deg)‖₀ := by |
There was a problem hiding this comment.
This lemma now returns a plain disjunction A ∨ B instead of the prior exclusive split (Xor' A B), which weakens the exported guarantee and prevents callers from deriving the mutual-exclusion property that Lemma 4.4 is documented to provide. Any downstream proof that relied on ruling out one branch from the other can no longer be reconstructed from this API, even when the old statement type-checked.
Useful? React with 👍 / 👎.
…#226 Verified-zkEVM#227 Verified-zkEVM#234) Complete AHIV22 proximity-gap proofs without semantic or signature drift and update file attribution to Elias Judin, Aristotle (Harmonic). Refs Verified-zkEVM#226 Verified-zkEVM#227 Verified-zkEVM#234 Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
eliasjudin
force-pushed
the
elias/issue-227-ahiv22-natcard-helper
branch
from
9a99ad5 to
51479d5
Compare
alexanderlhicks
requested changes
Mar 7, 2026
| * NB we use version 20221118:030830 | ||
| -/ | ||
|
|
||
| set_option linter.style.longFile 2000 |
Collaborator
There was a problem hiding this comment.
please remove this
| -/ | ||
|
|
||
| set_option linter.style.longFile 2000 | ||
| set_option linter.style.emptyLine false |
Collaborator
There was a problem hiding this comment.
please remove this
| `(𝔽ᵐ)ⁿ`. Let `e` be a positive integer such that `e < d/3` and `|𝔽| ≥ e`. | ||
| Suppose `d(U⋆, L^⋈m) > e`. Then, there exists `v⋆ ∈ L⋆` such that `d(v⋆, L) > e`, where `L⋆` is the | ||
| row-span of `U⋆`. -/ | ||
| private def vecSupport (u : ι → F) : Finset ι := |
Collaborator
There was a problem hiding this comment.
I feel like these could go into a supporting file to keep this one clean, but maybe best to leave this for now.
| if `v = 0`, the affine line degenerates to a singleton and the two branches can hold | ||
| simultaneously. | ||
| -/ | ||
| lemma e_leq_dist_over_3 |
Collaborator
There was a problem hiding this comment.
feels like this could follow more easily from e_leq_dist_over_3_strong?
Contributor
Author
|
@katyhr Let me know if this intersects/affects your planned work and what I can do / stay away from to help! |
Summary: - move the row-span and affine-line support lemmas into AHIV22Support - keep e_leq_dist_over_3 as an Xor wrapper around the strong lemma - remove local style overrides and regenerate the ArkLib import barrel Rationale: - satisfy PR Verified-zkEVM#385 review feedback without weakening public theorem contracts - bring AHIV22 under the long-file and empty-line lint requirements Tests: - lake exe cache get - lake build ArkLib.Data.CodingTheory.ProximityGap.AHIV22 - ./scripts/update-lib.sh - ./scripts/check-imports.sh - lake build ArkLib Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #226.
Closes #227.
Closes #234.
This PR completes the AHIV22 proximity-gap obligations in
ArkLib/Data/CodingTheory/ProximityGap/AHIV22.leanand removes the remaining proof gaps for Lemma 4.3, 4.4, and 4.5.It adds local helper lemmas for support/counting arguments and keeps the patched file free of
sorry,axiom, andprivate axiom, with local validation vialake build ArkLib.Data.CodingTheory.ProximityGap.AHIV22andlake build ArkLib.This PR adds proofs autoformalised by @Aristotle-Harmonic.
The resulting patch resolves the AHIV22 proof-wanted targets and references all associated issues.
It keeps all signature changes localized to
AHIV22.leanand validates downstream with a fullArkLibbuild.Co-authored-by: Aristotle (Harmonic) aristotle-harmonic@harmonic.fun