feat(Sumcheck/Simple): prove perfect completeness for single-round reduction#446
Open
XC0R wants to merge 1 commit intoVerified-zkEVM:mainfrom
Open
feat(Sumcheck/Simple): prove perfect completeness for single-round reduction#446XC0R wants to merge 1 commit intoVerified-zkEVM:mainfrom
XC0R wants to merge 1 commit intoVerified-zkEVM:mainfrom
Conversation
…duction Prove `Simple.reduction_perfectCompleteness` — the non-oracle single-round sumcheck reduction is perfectly complete. Both sorry branches closed via simulateQ layer-by-layer decomposition: support membership through OptionT/StateT/liftComp chains, guard resolution via Fin.snoc + norm_num, and outputRelation verification from concrete prover output structure. `oracleReduction_perfectCompleteness` follows structurally once `oracleVerifier_eq_verifier` (existing TODO) is resolved.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
🤖 Gemini PR SummaryCore Formalization
Technical Implementation
Statistics
Lean Declarations
✅ **Removed:** 1 `sorry`(s)
🎨 **Style Guide Adherence**The code changes have several style guide violations. Because there are more than 20 violations, they are grouped by the specific rule they violate:
📄 **Per-File Summaries**
Last updated: 2026-04-05 18:22 UTC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simple.reduction_perfectCompleteness— perfect completeness for thenon-oracle single-round sumcheck reduction (0 sorrys, was 2)
probEventproof closed:outputRelationafter full simulateQ decompositionoracleReduction_perfectCompletenessfollows onceoracleVerifier_eq_verifieris resolvedTechnique
Layer-by-layer
simulateQsupport decomposition:erw [simulateQ_bind]→StateT.run_bind→mem_support_bind_ifffor peeling,addLift_def+simulateQ_add_liftComp_*for liftComp stripping,norm_numaftersimp [Fin.snoc]for dite evaluation,Finset.sum_mapat hValid for guard matching.