Skip to content

feat(SplitFold): add splitNth_eval_comp_pow evaluation lemma#452

Merged
quangvdao merged 3 commits intoVerified-zkEVM:mainfrom
klausnat:evaluation_level_lemmas
Apr 10, 2026
Merged

feat(SplitFold): add splitNth_eval_comp_pow evaluation lemma#452
quangvdao merged 3 commits intoVerified-zkEVM:mainfrom
klausnat:evaluation_level_lemmas

Conversation

@klausnat
Copy link
Copy Markdown
Contributor

@klausnat klausnat commented Apr 9, 2026

  • Extract splitNth_eval_comp_pow from a local have in RoundConsistency.lean into a standalone lemma in SplitFold.lean
  • Refactor RoundConsistency.lean to use the new lemma, removing duplication

First of 4 evaluation-level lemmas needed for #450.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

🤖 Gemini PR Summary

Mathematical Formalization

  • Added splitNth_eval_comp_pow to SplitFold.lean, establishing the identity relating polynomial split components composed with $X^n$ to their evaluation at $x^n$.
  • The implementation contains no sorry or admit placeholders.

Refactoring


Statistics

Metric Count
📝 Files Changed 2
Lines Added 16
Lines Removed 10

Lean Declarations

✏️ **Added:** 1 declaration(s)
  • lemma splitNth_eval_comp_pow {n : ℕ} [NeZero n] (f : 𝔽[X]) (x : 𝔽) (i : Fin n) : in ArkLib/Data/Polynomial/SplitFold.lean

sorry Tracking

  • No sorrys were added, removed, or affected.

🎨 **Style Guide Adherence**

Based on the provided style guide, here are the violations found in the diff:

  • Line 327: ext e a
    • The variable e violates the Variable Conventions rule: m, n, k, ... : Natural numbers. (In this context, e represents a natural number index/exponent and should be n, m, or k).
    • The variable a violates the Variable Conventions rule: a, b, c, ... : Propositions. (The variable represents an element of a generic type/field, which should be x, y, or z).

📄 **Per-File Summaries**
  • ArkLib/Data/Polynomial/SplitFold.lean: This change introduces the lemma splitNth_eval_comp_pow, which establishes an identity relating the composition of split polynomial components with $X^n$ to their evaluation at $x^n$. This new theorem bridges coefficient-level definitions with evaluation-level reasoning and contains no sorry placeholders.
  • ArkLib/ProofSystem/Fri/RoundConsistency.lean: This change simplifies the proof of generalised_round_consistency_completeness by replacing a local helper lemma with the more general splitNth_eval_comp_pow theorem. It modifies existing proof logic without introducing new definitions or sorry placeholders.

Last updated: 2026-04-10 15:06 UTC.

@quangvdao quangvdao enabled auto-merge (squash) April 10, 2026 15:04
@quangvdao quangvdao merged commit b5d5002 into Verified-zkEVM:main Apr 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants