[PLAT-8122] Minor improvements to color util - #752
Open
aeischeid wants to merge 2 commits into
Open
Conversation
aeischeid
changed the title
aeischeid
marked this pull request as ready for review
April 24, 2026 21:08
aeischeid
force-pushed
the
colorUpdatesTry
branch
from
April 27, 2026 18:31
7e6705a to
8c549ac
Compare
|
aeischeid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make it so color util so can handle alpha channel for hex color stings and make a mildly more performant version of fromCss
Wasn't directly related to React or Stencil upgrades, but was sort of result of initial experiments towards that work which is why is is tagged with that issue.
Test Plan
Unit tests added and expanded
Test is vertex connect app, examples, or starter repo potentially
Could get good incidental coverage in manual and integration tests for 1.0 release testing
Release Notes
Should be no breaking changes
Now if using #rrggbbaa version of css hex colors has better chance of working
Possible Regressions
Not a regression, but a note as I looked into this - No gaurds against bad color numbers, for example. if user gave "rgb(453, -888, 515)" this is not a valid color, but chrome based browsers appear to just treat it as "rgb(255, 0, 255)"
Dependencies
n/a