Conversation
amvertex
left a comment
amvertex
left a comment
There was a problem hiding this comment.
Thanks for fixing all of these!
| </head> | ||
| <body> | ||
| <vertex-viewer id="viewer" class="viewer"> | ||
| <vertex-viewer-toolbar data-viewer="viewer"> |
There was a problem hiding this comment.
Do we not need the toolbar anymore?
There was a problem hiding this comment.
Nope! I've updated this to show the controls outside the viewer - the toolbar was really only used here for positioning, but taking a look at the example, these felt like they fit outside the viewer better anyway
There was a problem hiding this comment.
Cool! I like how it looks now.
|
aeischeid
left a comment
aeischeid
left a comment
There was a problem hiding this comment.
Nice cleanups! Looks ready to go 
| run: corepack enable | ||
| - name: "Install" | ||
| run: "yarn install" | ||
| run: "yarn install --ignore-scripts" |
There was a problem hiding this comment.
probably should have noticed and added this when I upgraded Lerna a bit ago
There was a problem hiding this comment.
Definitely an easy one to miss! The yarn install commands don't often get modified in PRs, so Sonar wasn't adding warnings to PRs frequently, and since the failure shows up post-merge, I've been missing this one as well 😅
3 participants
Summary
Currently, Sonar analysis of the master branch is failing due to a number of miscellaneous existing issues. This PR attempts to address most or all of the issues causing some of the categories to be below the level needed to pass.
Test Plan
Release Notes
N/A
Possible Regressions
Github workflows + scripts
Dependencies
N/A