Repository navigation
Conversation
Contributor
|
Looks like you might need to re-generate a few lockfiles, based on the test failures. As you already know, but also bears mentioning here so others know: there are still a few test failures for Rails 8.1 that I owe y'all a fix for. I've been super busy preparing for a speaking engagement, so I haven't been able to dedicate much time to it. Feel free to ignore for now 😄 |
Spone
force-pushed
the
drop-eol-rails-7.1
branch
from
October 30, 2025 09:14
c63048d to
ae0f9d6
Compare
Collaborator
Author
|
@camertron done! Do you think we release this as v4.x, or do we wait for v5.0? |
Member
|
@Spone @camertron per https://viewcomponent.org/compatibility.html#ruby--rails, this needs to wait for 5.0. |
joelhawksley
marked this pull request as draft
December 3, 2025 18:21
Member
|
I'm going to go ahead and close this as I'm guessing we will wait a while to ship v5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would this warrant a new major ViewComponent version? Do we want to keep Rails 7.1 support?