Skip to content

Restore Tracing Comments and Fix X Display in Scripts#147

Merged
GeneMosher merged 3 commits into
ViewTouch:masterfrom
No0ne558:master
Jun 19, 2025
Merged

Restore Tracing Comments and Fix X Display in Scripts#147
GeneMosher merged 3 commits into
ViewTouch:masterfrom
No0ne558:master

Conversation

@No0ne558

Copy link
Copy Markdown
Contributor

This pull request includes several code cleanups and environment fixes:

fntrace.cc

    Re-added missing copyright.

    Restored important trace logic comment: // depth == 0 means print the current function.

fntrace.hh

    Added explanatory comments for recent fixes.

    Corrected module reference.

    Included <cstring> on line 30 to resolve potential header issues.

Scripts:

    runonce, vt_pingcheck, vtclean, vtrestart, vtstart.sh

    Added export DISPLAY=:0 to ensure correct X display configuration.

report_zone.cc

    Added inline comments documenting recent changes and bugfixes.

No0ne558 added 3 commits June 19, 2025 01:31
- fntrace.cc: Re-added copyright notice and restored function trace
  comment on line 55 ("depth == 0 means print the current function").
- fntrace.hh: Documented fixes with inline comments, corrected module
  reference, and added `#include <cstring>` on line 30.
- Scripts (runonce, vt_pingcheck, vtclean, vtrestart, vtstart.sh):
  Added `export DISPLAY=:0` to ensure proper X display environment.
- report_zone.cc: Added comments to clarify recent fixes.
- fntrace.cc: Re-added copyright notice and restored function trace
  comment on line 55 ("depth == 0 means print the current function").
- fntrace.hh: Documented fixes with inline comments, corrected module
  reference, and added `#include <cstring>` on line 30.
- Scripts (runonce, vt_pingcheck, vtclean, vtrestart, vtstart.sh):
  Added `export DISPLAY=:0` to ensure proper X display environment.
- report_zone.cc: Added comments to clarify recent fixes.
@GeneMosher GeneMosher merged commit 58f70b4 into ViewTouch:master Jun 19, 2025
6 of 8 checks passed
@GeneMosher

GeneMosher commented Jun 19, 2025

Copy link
Copy Markdown
Member

The program is still hanging with the "Please Wait" message showing. Something in your initial code changes causes the program to hang, and export DISPLAY=:0 was not needed. Determining in your first changes that causes the breakage obviates the need to add export DISPLAY=:0 .
Is your new binary not also hanging on your machine ?

@No0ne558

Copy link
Copy Markdown
Contributor Author

Start from command.png

PXL_20250619_094053736.2.mp4

On my side it doesn't stop at please wait. I've tried it with the command and from the screen by tapping the green play button to start the program.

@GeneMosher

GeneMosher commented Jun 19, 2025 via email

Copy link
Copy Markdown
Member

@No0ne558

Copy link
Copy Markdown
Contributor Author

MY Raspberry Pi 5 POS Setup:

  1. Hardware Configuration:

Device: Raspberry Pi 5

Storage: 32 GB microSD card

Display: Single touchscreen monitor connected via:

Video: Micro HDMI to HDMI (connected to HDMI slot 0 on the Pi)

Touch Input & Power: USB to Micro USB cable (provides both power and touch data to display)

Input Devices: Touchscreen — no mouse or keyboard connected

  1. Operating System & Software:

Image Used: Official viewtouch.img written to the 32 GB SD card

Boot Behavior: Boots to the ViewTouch desktop environment.

User Interaction: From the desktop, ViewTouch applications can be launched manually via touchscreen

  1. Data Directory:

Preserved Configuration: All original data and configuration files from the image remain unchanged

No Modifications: Layout, menus, and other settings are untouched from the default image

  1. ViewTouch Executable Updates:

Binary Update: The latest Vt_data package from https://www.viewtouch.com/vt_data has been downloaded and added to the /usr/viewtouch/bin/ directory

  1. Network & Access:

Device is operated fully via touchscreen

Remote access (e.g. SSH) can be configured if needed for updates or support

@No0ne558

Copy link
Copy Markdown
Contributor Author

I'm at the restaurant and I updated the vt_data file to the new one and I got the "please wait" I reverted the vt_data file back and everything worked fine. I'll do further testing after work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants