Fix ListField Double-Touch Issues and Improve Order Comment Dialog#334
Merged
Conversation
- Fixed double-triggering when using touchscreen by changing ListFormZone handlers to use LayoutZone::Touch instead of FormZone::Touch - Fixed ListField click detection offset from .6 to 1 and boundary to match visual button area - Resolves issues in Tender Settings and all form zones with list fields
- Fixed double-triggering in ListFormZone by calling LayoutZone::Touch instead of FormZone::Touch - Fixed ListField click area boundaries to match visual button size - Redesigned Order Comment dialog with 6-row QWERTY keyboard layout - Added visible text entry box with absolute positioning - Implemented text display updates showing typed characters in RED - Added proper background clearing to prevent artifacting - Adjusted text positioning for better centering Work in progress: Still polishing the dialog keyboard implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes critical double-touch triggering bugs in form zones and begins improvements to the Order Comment dialog keyboard interface.
Changes
1. Fixed ListField Double-Touch and Click Area Issues
FormZone::Touch()ListFormZone::Touch()andListFormZone::Mouse()to callLayoutZone::Touch()instead, which only updates coordinates without triggering field actionslabel_width + .6tolabel_width + 1and boundary fromentry_width + 1toentry_widthto match visual button boundaries2. Order Comment Dialog Improvements (Work in Progress)
Files Modified
zone/form_zone.cc- ListFormZone Touch/Mouse handlers, ListField Touch detectionzone/user_edit_zone.cc- JobSecurityZone touch handlingzone/dialog_zone.cc- OrderCommentDialog constructor, Render, RenderEntry, DrawEntry, Signal methodszone/dialog_zone.hh- OrderCommentDialog interface changesdocs/changelog.md- Documentation of changesTesting