-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Automatically build logo collections #5
Conversation
Thanks! I think it would be nice to update the logos folder itself. I think the file sizes are all going to be small enough that it'll be ok to do so. |
I believe @cormullion may have a script to generate the image of all the logos. |
I'll add that this weekend. It's a bit tricky to test scripts like this so I'd rather not do too many changes in one PR. Since the PR itself doesn't change orgnames I triggered a build manually via the workflow dispatch. Thanks for the invite btw :) |
Yes, I have a Julia file that downloads the images named in However, there's a small problem ... There are so far four icons ("FourierFlows", "GiovineItalia", "HolyLab", "Julia-Streamers") that are JPG rather than PNG. Cairo doesn't accept PNGs, so I'd either have to script some kind of conversion (probably via Images.jl) or leave them out, or perhaps persuade the owners to convert to PNGism... 😂 I'll add the script tomorrow and you can decide... |
I would have thought that if we asked Github for PNGs, it would retrieve PNGs or error out... |
Indeed but it appears not to be the case:
(In this case we could ask @navidcy nicely to change to PNG, since they've contributed here already, but other repos might be less able to help...) |
I think the other repos will gladly accept a png if we send them one. :-) |
But it will be an ongoing battle. Best to be able to deal with both. |
I changed the logo to |
@navidcy Thanks for that! I ended up doing the conversion. One day GitHub might return a PNG version of a JPG icon when asked... :) |
This adds an Actions workflow that creates a release for every push to
main
that changes theorgnames
file. It'll attach a zipped and a tar'd copy of thelogos/
folder to the release.You can see it work on my fork of this repo:
It does not update the
logos/
folder itself, though. If that's something you want, I can add it in a follow-up PR.This doesn't quite solve the comment in the README but one could attach code that generates a pretty collection beneath it. I still think it's quite useful to download all logos at once without cloning the repo and rerunning the script.