chore: fix Docker Compose for local full-stack development#39
Merged
omolobamoyinoluwa-max merged 1 commit intoMay 28, 2026
Merged
Conversation
…relis#26) - Fix backend Dockerfile: use multi-stage build so tsc (devDependency) is available during the build stage; final image uses prod-only deps - Add healthcheck to backend service in docker-compose.yml - Change frontend depends_on to wait for backend service_healthy so the frontend container doesn't start before the API is ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #26
The
docker-compose.ymland README quick-start already existed, butdocker compose up --buildwould fail because the backend Dockerfile had a bug: it rannpm ci --omit=devbeforenpm run build, sotsc(a devDependency) was not available at build time.Changes
backend/Dockerfile— fix multi-stage buildnpm ci(all deps including devDeps) →npm run build(tsc compiles todist/)npm ci --omit=dev→ copies onlydist/from builder → lean production imagedocker-compose.yml— add healthcheck + proper startup orderinghealthcheckon the backend service (pollsGET /healthevery 10s)depends_ontocondition: service_healthyso the frontend container doesn't start before the backend API is readyAcceptance criteria
docker compose upstarts backend on :4000 and frontend on :3000docker-compose.ymlcomments (unchanged, already present)Tests
GET /health,GET /api/transfers,POST /api/freeze/build)npx tsc --noEmitclean