edge: add ProxyRoute.Service to retire host-substring service detection#48
Merged
Merged
Conversation
The service attribution in logProxyRequest used a string-match cascade against the Host header that ran in parallel to the route table — adding cargo.<domain> to BuildRoutes would route correctly but log as "proxy" because the cascade didn't know about the new host. This was the wart I flagged at the start of the split conversation. ProxyRoute now carries an optional Service string. BuildRoutesWithPorts sets it on every route whose traffic should be attributed (the cloudmock-internal rows leave it blank since logProxyRequest filters them out as internal traffic before reaching attribution). logProxyRequest reads route.Service first; the host-substring cascade stays as a fallback for hand-rolled route tables that don't set it. New TestBuildRoutes_ServiceLabels pins the mapping for both .localhost rows and primary-domain rows, plus asserts the internal routes leave Service blank. Closes #47 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`pkg/edge/proxy.go::logProxyRequest` (after #46) was attributing proxied requests via a string-match cascade against the Host header that ran parallel to the route table — adding `cargo.` would route correctly but log as `"proxy"` because the cascade didn't know about the new host. This is the wart I flagged at the start of the original split conversation.
`ProxyRoute` now carries an optional `Service string`. `BuildRoutesWithPorts` sets it on every route whose traffic should be attributed (the cloudmock-internal rows leave it blank since `logProxyRequest` filters them out as internal traffic before reaching attribution). `logProxyRequest` reads `route.Service` first; the host-substring cascade stays as a fallback for hand-rolled route tables that don't set it (backwards compat).
Closes #47.
Test plan
🤖 Generated with Claude Code