Skip to content

fix: update event handling for material modal to use onPointerDown #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VoX merged 1 commit into from
Feb 13, 2026
Merged

fix: update event handling for material modal to use onPointerDown #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,8 +578,8 @@ function App() {
</div>
</div>
{dropdownOpen && (
<div className="material-modal-overlay" onClick={() => setDropdownOpen(false)}>
<div className="material-modal" onClick={(e) => e.stopPropagation()} ref={menuRef} onScroll={(e) => { dropdownScrollRef.current = e.currentTarget.scrollTop }}>
<div className="material-modal-overlay" onPointerDown={() => setDropdownOpen(false)}>
<div className="material-modal" onPointerDown={(e) => e.stopPropagation()} ref={menuRef} onScroll={(e) => { dropdownScrollRef.current = e.currentTarget.scrollTop }}>
Comment on lines +581 to +582

Copilot AI Feb 13, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using onPointerDown instead of onClick for modal overlay dismissal changes the user experience - the modal now closes on pointer-down rather than on a complete click (pointer-down + pointer-up). This means users cannot change their mind by moving the pointer away before releasing. This is a deviation from common modal interaction patterns and may negatively impact user experience. Additionally, the settings modal at lines 605-606 still uses onClick for the same pattern, creating an inconsistency across the application. Consider whether this change is intentional and necessary, and if so, apply it consistently to both modals.

Suggested change
<div className="material-modal-overlay" onPointerDown={() => setDropdownOpen(false)}>
<div className="material-modal" onPointerDown={(e) => e.stopPropagation()} ref={menuRef} onScroll={(e) => { dropdownScrollRef.current = e.currentTarget.scrollTop }}>
<div className="material-modal-overlay" onClick={() => setDropdownOpen(false)}>
<div className="material-modal" onClick={(e) => e.stopPropagation()} ref={menuRef} onScroll={(e) => { dropdownScrollRef.current = e.currentTarget.scrollTop }}>

Copilot uses AI. Check for mistakes.
{categories.map((cat) => (
<div key={cat.label} className="material-category">
<div className="material-category-label">{cat.label}</div>
Expand Down
Loading