Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: turn off earth state panel #1350

Merged
merged 1 commit into from
Mar 30, 2025
Merged

fix: turn off earth state panel #1350

merged 1 commit into from
Mar 30, 2025

Conversation

TobiTenno
Copy link
Member

@TobiTenno TobiTenno commented Mar 30, 2025

Summary:
earth & cetus timers merged in 38.5.0
drop more earth


Fixes issue (include link):


Mockups, screenshots, evidence:

Summary by CodeRabbit

  • Refactor
    • Removed the Earth cycle time display from the main timer view.
    • Updated the display logic by eliminating Earth-specific conditions.
    • Consolidated cycle information so that Earth data now appears merged with the Cetus cycle, now labeled as "Cetus/Earth".
  • Bug Fixes
    • Updated location references for the "cetus" component to provide clearer context.

@TobiTenno TobiTenno requested a review from a team as a code owner March 30, 2025 21:27
Copy link

vercel bot commented Mar 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
warframe-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2025 9:27pm

Copy link

coderabbitai bot commented Mar 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request removes the Earth cycle functionality from the application. The EarthTimer component, along with its computed properties and render logic, has been eliminated from the AggregatedTimePanel.jsx. The computed property displayAggregate in pages/index.vue has been updated to remove any conditions referencing Earth. Additionally, the static configuration and localization files have been modified to merge Earth details into the Cetus entity, resulting in the removal of separate Earth entries.

Changes

File(s) Change Summary
components/panels/AggregatedTimePanel.jsx Removed the EarthTimer component along with its associated computed properties and rendering logic.
pages/index.vue Updated the displayAggregate computed property by removing the Earth display condition, now only checking other component states.
static/json/components.json, static/lang/en.json Updated configuration/localization: merged Earth details into the Cetus entity by renaming to "Cetus/Earth" and removed all separate Earth entries.

Sequence Diagram(s)

sequenceDiagram
    participant Panel as AggregatedTimePanel
    participant WorldState as WorldState
    participant OtherTimers as Other Timer Components
    Note over Panel: Render flow in AggregatedTimePanel
    Panel->>WorldState: Retrieve cycle data (cetus, earth)
    alt Previous Flow (with EarthTimer)
        Panel->>EarthTimer: Render Earth timing data
        EarthTimer-->>Panel: JSX with Earth cycle info & TimeBadge
    else Current Flow
        Panel->>OtherTimers: Render available timer components (without EarthTimer)
    end
Loading
sequenceDiagram
    participant Index as pages/index.vue
    participant State as componentState
    Note over Index: Computed property evaluation for displayAggregate
    Index->>State: Check display conditions (cetus, vallis, etc.)
    Note right of State: Condition for earth has been removed
    State-->>Index: Returns display state for aggregate view
Loading

Possibly related PRs

Suggested reviewers

  • EricSihaoLin
  • SlayerOrnstein

Poem

(_/)
Hop, hop, our code is neat,
The Earth is gone, now Cetus/Earth takes the beat.
Bugs scatter like carrots dancing in spring rain,
Each deleted line whispers a cleaner refrain.
CodeRabbit hops in joy—a bunny’s code delight!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a490c81 and 83907b6.

📒 Files selected for processing (4)
  • components/panels/AggregatedTimePanel.jsx (0 hunks)
  • pages/index.vue (1 hunks)
  • static/json/components.json (1 hunks)
  • static/lang/en.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes functionality related to the Earth state panel from the application.

  • Removed the Earth timer display check from pages/index.vue.
  • Removed the EarthTimer component and its corresponding reference from AggregatedTimePanel.jsx.

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
pages/index.vue Removed the condition checking for the earth state display.
components/panels/AggregatedTimePanel.jsx Removed the EarthTimer component and its usage in the render flow.
Files not reviewed (2)
  • static/json/components.json: Language not supported
  • static/lang/en.json: Language not supported

Copy link
Member

@SlayerOrnstein SlayerOrnstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TobiTenno TobiTenno enabled auto-merge (squash) March 30, 2025 21:28
@TobiTenno TobiTenno merged commit 88627b0 into dev Mar 30, 2025
7 of 8 checks passed
@TobiTenno TobiTenno deleted the no-standalone-earth branch March 30, 2025 21:28
wfcd-bot-boi pushed a commit that referenced this pull request Mar 30, 2025
## [2.5.5](v2.5.4...v2.5.5) (2025-03-30)

### Bug Fixes

* turn off earth state panel ([#1350](#1350)) ([88627b0](88627b0))
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 2.5.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants