-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: turn off earth state panel #1350
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request removes the Earth cycle functionality from the application. The Changes
Sequence Diagram(s)sequenceDiagram
participant Panel as AggregatedTimePanel
participant WorldState as WorldState
participant OtherTimers as Other Timer Components
Note over Panel: Render flow in AggregatedTimePanel
Panel->>WorldState: Retrieve cycle data (cetus, earth)
alt Previous Flow (with EarthTimer)
Panel->>EarthTimer: Render Earth timing data
EarthTimer-->>Panel: JSX with Earth cycle info & TimeBadge
else Current Flow
Panel->>OtherTimers: Render available timer components (without EarthTimer)
end
sequenceDiagram
participant Index as pages/index.vue
participant State as componentState
Note over Index: Computed property evaluation for displayAggregate
Index->>State: Check display conditions (cetus, vallis, etc.)
Note right of State: Condition for earth has been removed
State-->>Index: Returns display state for aggregate view
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes functionality related to the Earth state panel from the application.
- Removed the Earth timer display check from pages/index.vue.
- Removed the EarthTimer component and its corresponding reference from AggregatedTimePanel.jsx.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
pages/index.vue | Removed the condition checking for the earth state display. |
components/panels/AggregatedTimePanel.jsx | Removed the EarthTimer component and its usage in the render flow. |
Files not reviewed (2)
- static/json/components.json: Language not supported
- static/lang/en.json: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## [2.5.5](v2.5.4...v2.5.5) (2025-03-30) ### Bug Fixes * turn off earth state panel ([#1350](#1350)) ([88627b0](88627b0))
🎉 This PR is included in version 2.5.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Summary:
earth & cetus timers merged in 38.5.0
drop more earth
Fixes issue (include link):
Mockups, screenshots, evidence:
Summary by CodeRabbit