Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Clear-Site-Data Clear Cache interaction with prerender #361

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Add Clear-Site-Data Clear Cache interaction with prerender #361

merged 4 commits into from
Feb 10, 2025
+10 −0

Conversation

srwei
Copy link
Contributor

@srwei srwei commented Feb 6, 2025

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Preview:

domenic
domenic reviewed Feb 6, 2025
View reviewed changes
@domenic
Copy link
Collaborator

domenic commented Feb 6, 2025

ipr — PR has contribution issues. The following users' affiliation could not be determined: @srwei.

For this, you can work to link your GitHub account and your W3C account, and ensure your W3C account joins the WICG.

domenic
domenic reviewed Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked good and then I looked at the build result and realized we had some minor updates to make. But the normative content is solid and we can merge as soon as those minor fixes are done.

@domenic domenic merged commit d60ce7c into WICG:main Feb 10, 2025
2 checks passed
aarongable pushed a commit to chromium/chromium that referenced this pull request Feb 12, 2025
@srwei
Cancels prerenders when browsing data removal is run.
893cb02 
This change cancels all the existing prerenders when browsing data
removal is run on cached data. This can be triggered by the Delete Browsing Data option or with Clear-Site-Data response headers. Developer Tools will now also show the previously successful prerender(s) as failed. A new PrerenderFinalStatus is added specifically for this case.

nav-speculation spec PR: WICG/nav-speculation#361

NO_IFTTT=Changes for PrerenderFinalStatus will be done in separate repositories.

Bug: 40262311
Change-Id: Ie82895e555f3a9d4e2576686223e67443d198353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6173154
Reviewed-by: Ayu Ishii <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Steven Wei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1419494}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 12, 2025
@srwei @chromium-wpt-export-bot
Cancels prerenders when browsing data removal is run.
5136bb5 
This change cancels all the existing prerenders when browsing data
removal is run on cached data. This can be triggered by the Delete Browsing Data option or with Clear-Site-Data response headers. Developer Tools will now also show the previously successful prerender(s) as failed. A new PrerenderFinalStatus is added specifically for this case.

nav-speculation spec PR: WICG/nav-speculation#361

NO_IFTTT=Changes for PrerenderFinalStatus will be done in separate repositories.

Bug: 40262311
Change-Id: Ie82895e555f3a9d4e2576686223e67443d198353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6173154
Reviewed-by: Ayu Ishii <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Steven Wei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1419494}
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Feb 12, 2025
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 12, 2025
@srwei @chromium-wpt-export-bot
Cancels prerenders when browsing data removal is run.
c1577d0 
This change cancels all the existing prerenders when browsing data
removal is run on cached data. This can be triggered by the Delete Browsing Data option or with Clear-Site-Data response headers. Developer Tools will now also show the previously successful prerender(s) as failed. A new PrerenderFinalStatus is added specifically for this case.

nav-speculation spec PR: WICG/nav-speculation#361

NO_IFTTT=Changes for PrerenderFinalStatus will be done in separate repositories.

Bug: 40262311
Change-Id: Ie82895e555f3a9d4e2576686223e67443d198353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6173154
Reviewed-by: Ayu Ishii <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Steven Wei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1419494}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 18, 2025
@srwei @moz-wptsync-bot
Bug 1947888 [wpt PR 50666] - Cancels prerenders when browsing data re…
30d1ccf 
…moval is run., a=testonly

Automatic update from web-platform-tests
Cancels prerenders when browsing data removal is run.

This change cancels all the existing prerenders when browsing data
removal is run on cached data. This can be triggered by the Delete Browsing Data option or with Clear-Site-Data response headers. Developer Tools will now also show the previously successful prerender(s) as failed. A new PrerenderFinalStatus is added specifically for this case.

nav-speculation spec PR: WICG/nav-speculation#361

NO_IFTTT=Changes for PrerenderFinalStatus will be done in separate repositories.

Bug: 40262311
Change-Id: Ie82895e555f3a9d4e2576686223e67443d198353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6173154
Reviewed-by: Ayu Ishii <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Steven Wei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1419494}

--

wpt-commits: c1577d03f55f932e33a86fe0553b1f0fa5bfd8d1
wpt-pr: 50666
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Feb 19, 2025
@srwei @moz-wptsync-bot
Bug 1947888 [wpt PR 50666] - Cancels prerenders when browsing data re…
88a6445 
…moval is run., a=testonly

Automatic update from web-platform-tests
Cancels prerenders when browsing data removal is run.

This change cancels all the existing prerenders when browsing data
removal is run on cached data. This can be triggered by the Delete Browsing Data option or with Clear-Site-Data response headers. Developer Tools will now also show the previously successful prerender(s) as failed. A new PrerenderFinalStatus is added specifically for this case.

nav-speculation spec PR: WICG/nav-speculation#361

NO_IFTTT=Changes for PrerenderFinalStatus will be done in separate repositories.

Bug: 40262311
Change-Id: Ie82895e555f3a9d4e2576686223e67443d198353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6173154
Reviewed-by: Ayu Ishii <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Steven Wei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1419494}

--

wpt-commits: c1577d03f55f932e33a86fe0553b1f0fa5bfd8d1
wpt-pr: 50666
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Feb 25, 2025
@srwei @moz-wptsync-bot
Bug 1947888 [wpt PR 50666] - Cancels prerenders when browsing data re…
85c3f75 
…moval is run., a=testonly

Automatic update from web-platform-tests
Cancels prerenders when browsing data removal is run.

This change cancels all the existing prerenders when browsing data
removal is run on cached data. This can be triggered by the Delete Browsing Data option or with Clear-Site-Data response headers. Developer Tools will now also show the previously successful prerender(s) as failed. A new PrerenderFinalStatus is added specifically for this case.

nav-speculation spec PR: WICG/nav-speculation#361

NO_IFTTT=Changes for PrerenderFinalStatus will be done in separate repositories.

Bug: 40262311
Change-Id: Ie82895e555f3a9d4e2576686223e67443d198353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6173154
Reviewed-by: Ayu Ishii <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Steven Wei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1419494}

--

wpt-commits: c1577d03f55f932e33a86fe0553b1f0fa5bfd8d1
wpt-pr: 50666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srwei @domenic