chore: simplify dev and test tooling - #277
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe development command now runs the CLI in watch mode. The test command discovers TypeScript tests through a glob with serial concurrency. The typecheck command now runs only ChangesDevelopment workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR simplifies development, testing, and type-checking commands without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR simplifies development and test tooling by replacing the custom development supervisor with
Confidence Score: 4/5The development-tooling change should be fixed before merging because the server no longer recovers automatically after an unexpected startup exit. The new Files Needing Attention: package.json, scripts/dev-server.mjs
|
| Filename | Overview |
|---|---|
| package.json | Simplifies test, typecheck, and development commands, but the new development command loses automatic recovery after startup failures. |
| scripts/dev-server.mjs | Deletes the custom watcher and supervisor, including its delayed restart behavior after unexpected child exits. |
Reviews (1): Last reviewed commit: "chore(dev): use tsx watch for reloads" | Re-trigger Greptile
Adding a test currently requires manually extending the package test command, while local server reloads are maintained by a custom watcher and process supervisor. This makes
*.test.tsnaming the source of truth while preserving serial execution, and keeps type checking focused on TypeScript only.Local development now uses tsx’s built-in watch mode directly, removing the custom reload supervisor while preserving source-change restarts and clean shutdown behavior.
Summary by CodeRabbit