Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shelf code + static site with STLs as build action #22

Merged
merged 24 commits into from
Feb 29, 2024
Merged

Conversation

drayde
Copy link
Contributor

@drayde drayde commented Feb 27, 2024

Hey @jmwright , can you have a look?
Please do not merge yet, need to change github pages configuration together with the merge, I'll do both in one go

@drayde drayde requested a review from jmwright February 27, 2024 16:05
Copy link
Collaborator

@julianstirling julianstirling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. A couple of my comments are just comments and don't need changes. But I would change the requirements.txt and the font one before mergeing

Copy link
Contributor

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @drayde !

@drayde drayde merged commit a682fc9 into smart_doc Feb 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants